From patchwork Mon Aug 29 18:58:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marvin Schmidt X-Patchwork-Id: 17238 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 13EBEC327D for ; Mon, 29 Aug 2022 18:59:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BDDD361FC9; Mon, 29 Aug 2022 20:59:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1661799546; bh=Jos+LhCNs18cwF+Un9F40PUKpM8/yLawM1pih7TPZus=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=wwXIMNr9Eu1shmC7VEIik5XOTPAaJBLTOjGSTYzcpoZApulczaHn+M1JEkRihWmV9 Zw9qMHTAyIK8Uv83z0DgI0+P4vbKNfDz86HiUA0wJ4TC0u1kbG5MA+9cG+E4wBJ4UE rlEYWmrfqKPCj9ONOxiRcgVJU+LQVRbvzbXC1qeb0FRHU2B/G7K68d/LiM9GvnCkok CqO7hV+UkCD8si9ui9vT3VTw3Tkc33lm6TTbhTcpAwTb/XzAh2oVI6/pwKNTyId8q4 PWrYFk3GJEwBA7elGBn3omzKupBjf+9RuYBgvPz85i9gRrrnS4caK1Zn4urgmxVM/U XSmAywIhBrbBg== Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 13F4261FC3 for ; Mon, 29 Aug 2022 20:59:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bOqUaBLl"; dkim-atps=neutral Received: by mail-ed1-x530.google.com with SMTP id z41so3941094ede.0 for ; Mon, 29 Aug 2022 11:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=2OlmZP7JRnr9HHxNIH683hvLfcTV3E+NkjsSXmg0f3Q=; b=bOqUaBLlt+XdCMmCqw5KdfHZIo+Dg2Y6dHGPT6AeSb8FEUdTGs8nKoXZKBlYlw/iHW 8iDThDxHdESJDBDIuIbLaDpE9NEqHzOEIDbwJwy4rkO1SoWpDx9gWIYhi3GmWK3Rx7mI 8GSmKtMc4nwf4U0YzoZs72OZlWobwWVJjmN2DMtXqwnjJZlGWGZFmjr73As/mp/+WoDt YnJExY/FqHeb3oQcWiOQ3HKeXBsjkRsMyhXxZBTkdVZuseypykDQu9QgI8aTfsPoRhgN rRKlb9cgLCcmgw6/7lLbv17cf8VREyCNm9hc7vgJQ2Q+dAv1RpvPMTFP/AqpmPAY+as/ 6QGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=2OlmZP7JRnr9HHxNIH683hvLfcTV3E+NkjsSXmg0f3Q=; b=yLBpf//9cSHlB9KLtRTnOOJrv0gcyrdxO9JeiEjW05DFDIVg9xd3ETlziidYpRsn2B P6GbhxE+SKVF7jaouIBkxMFNgS2+OBwMkpquh54RTNzYJ/AhxgWnByGE3VxtJNd14mpp E1LTuEGhdeEPotCG5mx3LlVBwM8e1MyUVcBPIOWBQXcCtHST19HHMDWIWg1m+sxwQy5k 3z9u9Moune96GNj1q3ihVjPnTSKcUHMsB/cSFd6xbKg+WvdU6fozxVdQcK6jTF1oyZev wrA27YfKzjzpzDxVF3iUP3mqDlr2S5OrvRx1WxIuZTIkAE4eiRXqtwdm+0reW4HYVm4p m1wA== X-Gm-Message-State: ACgBeo0AEhVyG1xPImLC42NaLgkM/E3i9fBZHpwmbKzQzo907rK0fA92 ZvviZ1uScBalZ97iKS8y0p45pWcWqok= X-Google-Smtp-Source: AA6agR52BLNCvQR92rNV4oe3NeW1pU6VxZhaVBHx0waVNdvEuoDK+ODuHlkCvA8dZMutYEY3fpoBnw== X-Received: by 2002:a05:6402:290d:b0:448:32f5:1e7 with SMTP id ee13-20020a056402290d00b0044832f501e7mr8779461edb.50.1661799542383; Mon, 29 Aug 2022 11:59:02 -0700 (PDT) Received: from pythagoras.local (dynamic-077-003-143-111.77.3.pool.telefonica.de. [77.3.143.111]) by smtp.gmail.com with ESMTPSA id 17-20020a170906211100b006fef0c7072esm4828136ejt.144.2022.08.29.11.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 11:59:01 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Aug 2022 20:58:48 +0200 Message-Id: <20220829185849.1884517-3-marvin.schmidt1987@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220829185849.1884517-1-marvin.schmidt1987@gmail.com> References: <20220829185849.1884517-1-marvin.schmidt1987@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/3] ipa: ipu3: Remove redundant call of std::string::c_str() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Marvin Schmidt via libcamera-devel From: Marvin Schmidt Reply-To: Marvin Schmidt Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The constructor of libcamera::File takes a const reference to a std::string and clang-tidy's readability-redundant-string-cstr check warns about it: > ../src/ipa/ipu3/ipu3.cpp:330:12: warning: redundant call to 'c_str' [readability-redundant-string-cstr] > File file(settings.configurationFile.c_str()); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > settings.configurationFile Signed-off-by: Marvin Schmidt --- src/ipa/ipu3/ipu3.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index e37b2fa0..e3c1e816 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -327,7 +327,7 @@ int IPAIPU3::init(const IPASettings &settings, context_.configuration.sensor.lineDuration = sensorInfo.lineLength * 1.0s / sensorInfo.pixelRate; /* Load the tuning data file. */ - File file(settings.configurationFile.c_str()); + File file(settings.configurationFile); if (!file.open(File::OpenModeFlag::ReadOnly)) { int ret = file.error(); LOG(IPAIPU3, Error)