From patchwork Mon Aug 29 13:59:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marvin Schmidt X-Patchwork-Id: 17226 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CCBFCC3272 for ; Mon, 29 Aug 2022 13:59:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 261B661FC0; Mon, 29 Aug 2022 15:59:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1661781597; bh=yOcotqSmJSAdpQPlQuCCGehmuIwgQ6sMo/McP7zTF3I=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Vz7nmTnAq3zIGgzmJ6oeBM4aVyjWXL7vqCGkLP+X4qpe97N3SFxTOSTR/zVlHvfmR 8pYCZt6YSCAFjKDYJJAbGg/6Ugle+EO9c8r2TvO2mlaRhUFX8YE0VU7faevm5NpslW ggK3IiTDkNFYAe1OK3oWAa9/piZ37B53PdfDAKytFcmJq/F0CqY5CPJm5Np3SCRmVV yeZh1qg8Ls1RLDEUXqSuKETA11urKZM+uw3V31wma9OvDXvQQMjDchU13clJc/9ZPf 4nxLomgc4Wze1JmrmQFvT2d5gikTy2y+9znhJI8318P9JAcX/RhnsuOvr1I2J2vasl yoF1//q6zMqzw== Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 92C8A61FBA for ; Mon, 29 Aug 2022 15:59:56 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ijP7o4Xa"; dkim-atps=neutral Received: by mail-ej1-x62e.google.com with SMTP id w19so15873952ejc.7 for ; Mon, 29 Aug 2022 06:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=Hh7M6UE0oNRA6ORmP5ohomPNt0cHcBnLPkLQ2S1RZUE=; b=ijP7o4XaqrcPcX52mqgjsAXfUMFPRya2F9v4LGsOeHMki/bmRaqernNN+JY7fuOIA9 ItkQ9Tud5Ne/Seu0ozPa0Ymv9LFxX1g+uCsbYzMUprGmGmkdntO1GP1D58GO1mc7XHTC Rw2T3UF5w2uxRjndVkjEt6md6tr8LSrrkSggP1lvlXzfVpOOfIwcQcV1q+greMxvoCzb c2gf+iH/M6IqmacThoElqdBU7i2vN804kkw/wh2s3I+JDZ7pIYBneL4uci0FJa0+9J4r MQ8fV7KlaES8rzzCPl/TWb5CxryHpXhKh8IgLw4LpCcAlM+onyuQaZfYHOMmnADlCpmC rE3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=Hh7M6UE0oNRA6ORmP5ohomPNt0cHcBnLPkLQ2S1RZUE=; b=cdKKaGo1ByNMKcn9mAPEGAvfPp7h517p+4hW9ZQ3Yx0cXiLv947FeTeke960shXmdI 5rXq++3j9swTU9sIga+e0Lb/bFI7JZSBxwTGC93TY7ETwelbvckOo2DeVQbJqxcIPm61 NJx+dhiOB2Df0W0lT4SpCjUkQMq/m7g7pcBOoQLRZRAFoW1idSL243/xeyHZluj8MabO Yf9UkNLpghtX48Py6GbFTifMEW0rLeQgjaXnN7oHu/gPmYe3luA+iCGwsO/28Zg6tR3A MlFm6nuzOwHo3AAxQWu8Y6w9/v5gxugiA96JBgGVcg7/GVb8zU2GBOShFs9DZ+TUHLYz 1FpQ== X-Gm-Message-State: ACgBeo0HxdPmlhnuarDKylUMryI2tEdm50cmSD/i///mb8n6xb7KMnNL RvTAA42unoeCEF+tIvn7px9tedkF7Gc= X-Google-Smtp-Source: AA6agR75lTnBWwstq8gHEMBlNbB3JfqgC14rl3/0w9cJoJhk66hCjn2JbkR9HC3A8URtK2JzSMiIsg== X-Received: by 2002:a17:907:7da0:b0:741:a1c5:bfa0 with SMTP id oz32-20020a1709077da000b00741a1c5bfa0mr1440643ejc.555.1661781595783; Mon, 29 Aug 2022 06:59:55 -0700 (PDT) Received: from pythagoras.local (dynamic-077-003-143-111.77.3.pool.telefonica.de. [77.3.143.111]) by smtp.gmail.com with ESMTPSA id a71-20020a509ecd000000b00446639c01easm5785527edf.44.2022.08.29.06.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 06:59:55 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Aug 2022 15:59:50 +0200 Message-Id: <20220829135950.1271098-1-marvin.schmidt1987@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: media_device: Fix \sa tags for MediaDevice::link X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Marvin Schmidt via libcamera-devel From: Marvin Schmidt Reply-To: Marvin Schmidt Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" doxygen didn't create proper links to the overloads of MediaDevice::link because the signatures didn't match due to an additional 'const' While at it remove the unnecessary `MediaDevice::` and wrap the lines Fixes: b65feafe ("libcamera: media_device: Add functions to get a MediaLink") Signed-off-by: Marvin Schmidt Reviewed-by: Laurent Pinchart Reviewed-by: Umang Jain --- src/libcamera/media_device.cpp | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp index 7c94da9e..52c8e66e 100644 --- a/src/libcamera/media_device.cpp +++ b/src/libcamera/media_device.cpp @@ -352,8 +352,9 @@ MediaEntity *MediaDevice::getEntityByName(const std::string &name) const * entity with name \a sourceName, to the pad at index \a sinkIdx of the * sink entity with name \a sinkName, if any. * - * \sa MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx, const MediaEntity *sink, unsigned int sinkIdx) const - * \sa MediaDevice::link(const MediaPad *source, const MediaPad *sink) const + * \sa link(const MediaEntity *source, unsigned int sourceIdx, + * const MediaEntity *sink, unsigned int sinkIdx) + * \sa link(const MediaPad *source, const MediaPad *sink) * * \return The link that connects the two pads, or nullptr if no such a link * exists @@ -381,8 +382,9 @@ MediaLink *MediaDevice::link(const std::string &sourceName, unsigned int sourceI * entity \a source, to the pad at index \a sinkIdx of the sink entity \a * sink, if any. * - * \sa MediaDevice::link(const std::string &sourceName, unsigned int sourceIdx, const std::string &sinkName, unsigned int sinkIdx) const - * \sa MediaDevice::link(const MediaPad *source, const MediaPad *sink) const + * \sa link(const std::string &sourceName, unsigned int sourceIdx, + * const std::string &sinkName, unsigned int sinkIdx) + * \sa link(const MediaPad *source, const MediaPad *sink) * * \return The link that connects the two pads, or nullptr if no such a link * exists @@ -404,8 +406,10 @@ MediaLink *MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx, * \param[in] source The source pad * \param[in] sink The sink pad * - * \sa MediaDevice::link(const std::string &sourceName, unsigned int sourceIdx, const std::string &sinkName, unsigned int sinkIdx) const - * \sa MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx, const MediaEntity *sink, unsigned int sinkIdx) const + * \sa link(const std::string &sourceName, unsigned int sourceIdx, + * const std::string &sinkName, unsigned int sinkIdx) + * \sa link(const MediaEntity *source, unsigned int sourceIdx, + * const MediaEntity *sink, unsigned int sinkIdx) * * \return The link that connects the two pads, or nullptr if no such a link * exists