From patchwork Fri Aug 19 11:16:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 17176 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 92A25BE173 for ; Fri, 19 Aug 2022 11:16:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 023D961FC6; Fri, 19 Aug 2022 13:16:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660907794; bh=fRRMCVBoNG8Bc6PNJEDWJE/dhM/dWtpWrWuxVQ6kOj4=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=IDxikQgk5EYPQg46S4JHqKeZ+oQ+4VjK3ixO8Xr2UJL5kKiGLeju5CQiNc0IKySEd u/L73Z7aYuNJfICwcIjjD2VVdknu115QtQhsUyQ9fCoc//pz0QWp++bIt+tvHbZdea CNOBqAog2rt31u6to1G4g/Hx4h7XROtvdwRn446maWPhoqPOa1jg4f2Tgq3YyI1lCP rSIz1A93r76pDhIVV6x3Z3cXKViMzw1kvYM06oDO/GitBI/ZAFKKcRbiTGXlWJw8y/ cBJKKAxh9sVzPHXZWWakkoTpYQBLQDjab+YCoDbsgcQzF/x+QJkILMDigaeI3lYKcu RLHq5JNA9jpUw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DE98761FA5 for ; Fri, 19 Aug 2022 13:16:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="AGBsq8c6"; dkim-atps=neutral Received: from deskari.lan (91-158-154-79.elisa-laajakaista.fi [91.158.154.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2AD5D576; Fri, 19 Aug 2022 13:16:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1660907790; bh=fRRMCVBoNG8Bc6PNJEDWJE/dhM/dWtpWrWuxVQ6kOj4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AGBsq8c61CBS93XsYh+/XKj62+hzi5as3yAN8UOOUz21xLjCOoi1LFnqRxWdsME4h unTjOv4dP9C9nTbgy8TAVMrP4cJNSqBVsT/QXRgbF0JNVN6Wg/ukxzb0AJNCAM2Ouh tj8YnCwret1K4XgYvhefcPOSK8DHcBsjo/iV4Kcc= To: libcamera-devel@lists.libcamera.org, David Plowman , Kieran Bingham , Laurent Pinchart , Jacopo Mondi Date: Fri, 19 Aug 2022 14:16:10 +0300 Message-Id: <20220819111615.39814-2-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220819111615.39814-1-tomi.valkeinen@ideasonboard.com> References: <20220819111615.39814-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 1/6] py: meson: Use libcamera_private dependency X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tomi Valkeinen via libcamera-devel From: Tomi Valkeinen Reply-To: Tomi Valkeinen Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" We define -DLIBCAMERA_BASE_PRIVATE to get access to libcamera private headers, but the correct way to do this is to have a meson dependency to libcamera_private. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- src/py/libcamera/meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build index 04578bac..99c2a8c0 100644 --- a/src/py/libcamera/meson.build +++ b/src/py/libcamera/meson.build @@ -60,7 +60,7 @@ pycamera_sources += custom_target('py_gen_formats', command : [gen_py_formats, '-o', '@OUTPUT@', '@INPUT@']) pycamera_deps = [ - libcamera_public, + libcamera_private, py3_dep, pybind11_dep, ] @@ -69,7 +69,6 @@ pycamera_args = [ '-fvisibility=hidden', '-Wno-shadow', '-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT', - '-DLIBCAMERA_BASE_PRIVATE', ] destdir = get_option('libdir') / ('python' + py3_dep.version()) / 'site-packages' / 'libcamera'