From patchwork Tue Aug 16 18:38:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17138 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 88A13BE173 for ; Tue, 16 Aug 2022 18:38:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A25B661FBC; Tue, 16 Aug 2022 20:38:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660675112; bh=TKl/bH6hDjXvaDwaz5+NOoWJGJVITPeq61cwGw1bAlU=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=AMA79q89Bxx7PtBXz7+QB01qnCyc7cOIWKi11pbAxxjvSvBFu8vmDZam5IWIdRYEX 19Ba+FnXRuYBlUITF+umQmXN/mHM5a5p/t73BR711nDzBLqMBDJO6/bZpRvaF2kWvM XTx4dfY4bzTugdXrEK+7uJGxXX8u97odxEUyiFm7rCKDXxEN2qXmkkOXgs6oU0i9sA UZVIlYrxADU8mURaDOO94TuLsncPjP6LGa79qzpkUo4OYR/AHOfDXOyIrFCncOAyvC X1Gj8Hot0fH019HBcKbkwQbDyJ1+Hrj6pKurZxJBxf7AMVzNkRf27TH2VxEDaYwnef Q8FhL0YGu86wQ== Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BEA561FA9 for ; Tue, 16 Aug 2022 20:38:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="MBJFn9iI"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660675109; bh=TKl/bH6hDjXvaDwaz5+NOoWJGJVITPeq61cwGw1bAlU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=MBJFn9iIS3jrFdz2004J9Y49TSi5vuzMydPrsVjUb/nEyTCkV8+G/kJFnMytwt6DJ 963S4tYAHAgIHBIG/H30D1xHKgeYRaKs9DzOCakrYtNQ0RiainMs51nfVF7AqP2nWD +BR70RMOGdldecJXoaRbPBSc8KLZ73yVWdIbV8x8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MmULx-1nfa1E2uqv-00iRXd; Tue, 16 Aug 2022 20:38:29 +0200 To: libcamera-devel@lists.libcamera.org Date: Tue, 16 Aug 2022 20:38:25 +0200 Message-Id: <20220816183826.102989-2-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220816183826.102989-1-Rauch.Christian@gmx.de> References: <20220816183826.102989-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:UAMPlQkLVOQThs0PcChzpRQDYlJqy0SYVSqaYAjYTs776ipCNbJ /1RdM33LA75h4ou0wS1J9dU+qPBmZ5ALWqiQkIlekuOQNAEont+9EODngJ7ED11p8yVgmex nNEp3h18dJa5StoA+QFXAb4EFZ5gziBDNvvNl9ag0lwnVHnuVWEixtvG2lMK94n9cKbtbC6 F6d3dTTwpRWHFjs3mg+TA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:h71FcNWhDjs=:HXxCVR0nEeph6fKsGr3apH 6kE6yRbbltxz3RUxw2pjA0xZDMaoMmB4e/gNDPDdT3l7DvcIAg7lwyB/hTq/oyw/L+8GuWL58 7w0wtJ5pOaT3c5E+OGULtrZ8KvAtmR4Vrecyd8LLP8EBW5HjlzWDDrPexG+vk+w1nvaJ1NRkI Co2HmkhLghRN7wmJY+qiTr6HGHFdSNjWcwQtulyY145H2UQ+Ipq1ZFexV0HGemgzkNuQpN7Vz UFbfS3x3Vq9vsFWPQmN8pcnRNwwTcfgi2tBQowMHzwVPeTCblDU2dvlyvoRzCWq5nuStAB6kV DVXqJyxa8LJvCjSw+6d1C/KRPrWlNWdzVAeDZZDfmvPJOgXuaFaK8JKLs6lgi+6hCs3tR7uW7 sFnksdb7/n+W6i71ME3rtMU6bJED9WyXIlmL7TE9aSrZYkBbOG82PRFTtInYLpQK1KEM0vzZ2 PzH3PwiXkqU3txELbj+c93dg8asdnLtgUVGfsWSHw3KVO28v8A7954orFEA3IWXscQKMcUUK8 mOwAvp4OaKebruqWsiw+78XQOMYCvbx5/mXMuYB9BdblQ9+3ucD7XnclVmpzw/E0eg+UzKaLT cAUGzMpq0YLWSxPZJFPEdAyGV5VCXHX3n5kdKrU/mT5DEKQZqCEPAEweUwQZcKm+2uYh2HRUg DnOQsO5ISukisYRyLOesN3QcqNZ+makugHkuYxC+voK9vYVbGUx2/eyv4sRSmJYYw8UZibXNT HJ8c0UQXoKqjuA8/5+au4ZKsuHbSVO7a5Mf6S6hTM5MiLCDF3WFY/0thUfepi+sOLYd0oXv9G cuNIxdfO07AwxRlRGayQ8rO0PTEqe242M4qgBthHq49rzNvdyEX+SvtrmkWfrsuRWRqQqenCg NKJ3TA5adzCYXpbSw8XfXb9j5zDr5mZUWB+6xEMBNPHsCXHi03go+T4L3g02ZgBYlf4vsSbwz 35gAF9eL+aXMrx7s3UdGrAgHOvueS5YYpb/+oaVCgWuWKLxYr14H8PTbnJJrR0BHRnwVZKwFz chEWq5YQWqxnzpWCL2DvAUCLV/mi36EKwJAzz/SPUU/UXcBoDVQV5Fm1EjZEMxQC4ZP5FBGlq ts/i25g61DyKhpXKfHCipPea3DQy40BGWwdQ4QWq2q/iEUMOKvMwYymOA== Subject: [libcamera-devel] [PATCH v2 2/3] libcamera: use const reference for range loops X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A const reference prevents unnecessary copies of the loop elements. Signed-off-by: Christian Rauch Reviewed-by: Laurent Pinchart --- src/libcamera/camera_manager.cpp | 2 +- src/libcamera/device_enumerator.cpp | 2 +- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 +----- src/libcamera/pipeline/vimc/vimc.cpp | 2 +- src/libcamera/pipeline_handler.cpp | 2 +- 5 files changed, 5 insertions(+), 9 deletions(-) -- 2.34.1 diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp index 70d73822..7ff4bc6f 100644 --- a/src/libcamera/camera_manager.cpp +++ b/src/libcamera/camera_manager.cpp @@ -189,7 +189,7 @@ void CameraManager::Private::addCamera(std::shared_ptr camera, { MutexLocker locker(mutex_); - for (std::shared_ptr c : cameras_) { + for (const std::shared_ptr &c : cameras_) { if (c->id() == camera->id()) { LOG(Camera, Fatal) << "Trying to register a camera with a duplicated ID '" diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp index d1258050..f2e055de 100644 --- a/src/libcamera/device_enumerator.cpp +++ b/src/libcamera/device_enumerator.cpp @@ -161,7 +161,7 @@ std::unique_ptr DeviceEnumerator::create() DeviceEnumerator::~DeviceEnumerator() { - for (std::shared_ptr media : devices_) { + for (const std::shared_ptr &media : devices_) { if (media->busy()) LOG(DeviceEnumerator, Error) << "Removing media device " << media->deviceNode() diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp index fbe02cdc..9cbf126a 100644 --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp @@ -340,12 +340,8 @@ int PipelineHandlerUVC::processControls(UVCCameraData *data, Request *request) { ControlList controls(data->video_->controls()); - for (auto it : request->controls()) { - unsigned int id = it.first; - ControlValue &value = it.second; - + for (const auto &[id, value] : request->controls()) processControl(&controls, id, value); - } for (const auto &ctrl : controls) LOG(UVC, Debug) diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp index 153cf849..d2f2e460 100644 --- a/src/libcamera/pipeline/vimc/vimc.cpp +++ b/src/libcamera/pipeline/vimc/vimc.cpp @@ -378,7 +378,7 @@ int PipelineHandlerVimc::processControls(VimcCameraData *data, Request *request) { ControlList controls(data->sensor_->controls()); - for (auto it : request->controls()) { + for (const auto &it : request->controls()) { unsigned int id = it.first; unsigned int offset; uint32_t cid; diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index 7d2d00ef..e5cb751c 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -616,7 +616,7 @@ void PipelineHandler::disconnect() */ std::vector> cameras{ std::move(cameras_) }; - for (std::weak_ptr ptr : cameras) { + for (const std::weak_ptr &ptr : cameras) { std::shared_ptr camera = ptr.lock(); if (!camera) continue;