From patchwork Fri Aug 5 13:53:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 16978 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E9998C3275 for ; Fri, 5 Aug 2022 13:53:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B4B3E6332F; Fri, 5 Aug 2022 15:53:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1659707606; bh=2AuALeaWK3ekNcY6FS53UwHJn0pgH0MB7qqVKxmO7eo=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xj1NWFy4xp14oZylMD1XaaYcgdI+vFfB7DGvKiZinfQ83jWIvFV07S/wuhKnwFeGe Rh8ZsAp+Y3GU6WLd1Ef8zUuW+kH3KNYDf6BGAp7fG1rcQrwm4LWvZGyZNrk/8H437W GsnaKFq5rfG0KDewz6yQ16sroyogznHpawMUB2PkZ7+Ewqb7uZiCU8//5dWMvTGxgH JnVPiOGaV/T9eSCwMtby1xm51cgoNBzQzAKW6yzaNMZO1ZJ1gWXCUNgxpV1Ceh8LcV i4LEW44xSUnIpr6BH1BlM5Yiu4cylSzcRCS6PP9EV5nXB/+dG20aFFQsHnB7EE44Sw scdqkck1Bd2UA== Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 30F89603E4 for ; Fri, 5 Aug 2022 15:53:24 +0200 (CEST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id 848F71C0012; Fri, 5 Aug 2022 13:53:23 +0000 (UTC) To: libcamera-devel@lists.libcamera.org Date: Fri, 5 Aug 2022 15:53:05 +0200 Message-Id: <20220805135312.47497-4-jacopo@jmondi.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220805135312.47497-1-jacopo@jmondi.org> References: <20220805135312.47497-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 03/10] libcamera: request: Add PFCError flag X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jacopo Mondi via libcamera-devel From: Jacopo Mondi Reply-To: Jacopo Mondi Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Kieran Bingham via libcamera-devel Provide a new flag for the Request error state to indicate that a per-frame control error has occurred. One or more controls set for this request could not be guaranteed on this frame. Signed-off-by: Kieran Bingham Reviewed-by: Jacopo Mondi Signed-off-by: Jacopo Mondi Reviewed-by: Umang Jain --- include/libcamera/request.h | 1 + src/libcamera/request.cpp | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/include/libcamera/request.h b/include/libcamera/request.h index 3304da31200d..9aee81922c91 100644 --- a/include/libcamera/request.h +++ b/include/libcamera/request.h @@ -47,6 +47,7 @@ public: enum ErrorFlag { NoError = 0, ControlError = (1 << 0), + PFCError = (1 << 1), }; using Errors = Flags; diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 9a808f19fc03..b93eaac75880 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -346,6 +346,10 @@ void Request::Private::timeout() * Control Error. At least one control was not applied correctly to the camera. * The application should compare the metadata to the requested control values * to check which controls weren't applied. + * + * \var Request::PFCError + * A per-frame-control error has occured. Controls that were expected to be set + * during the processing of this request were not processed in time. */ /**