From patchwork Thu Jul 28 12:05:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 16862 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 58E13BE173 for ; Thu, 28 Jul 2022 12:05:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 253DD63312; Thu, 28 Jul 2022 14:05:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1659009937; bh=uWPJLtQyZJd4Yz+5VvhrXNnqC7k7NykfEWwUdvRkid0=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=YhI24gaq67PbB90Cr7xnouqJtmDVwu2L44WnefKBFbf1fXs3mAZSngwo7zx0l9gwj /i3iyQMaTnXg7VTT/xo95xOnQH26WTizc0ZpgRiLW9Hy/0PFh7bfSuX61fW3UWX2C8 KcUCKmsX2DM1KoCdVsDjyiEBIs18xOzyq/5xWo4TQk0uQGQsRFHtQ39tv31yjDGqxS d0fxr+dwAX4fl2ddol313tYI+cJs1kbPhYj+IjJDgFblHOqqxhIABOSUKN8mk0iULb XhwEdQvdGX8mOP617ewMZzyfiBcsHgixcLT1FuYTk3ApOXh7YF67W64rPa/aMwTME8 qC62wWUD/Roow== Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D24D6330D for ; Thu, 28 Jul 2022 14:05:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="TCT4u0T2"; dkim-atps=neutral Received: by mail-wr1-x432.google.com with SMTP id u5so1923463wrm.4 for ; Thu, 28 Jul 2022 05:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J3GjYIYwifSay6HDg+VFEcdCVrSEjynp26pTorRquDM=; b=TCT4u0T2oazX5YOfz44o7gcwkcB8leOAxA1PofSMPYE2KNzqILciopLwqJBhgT80Ov f8bdr2vrIDrzxhXXy1H+lfwip+E29ce0VezS4EWLYF74Brgcy7xTleW1XabycOtkgdTO kYl3XDgpnktoBkoYMc1XA8pgc2SJJvwl763mt6hFU039h3zbPWwZsSYYTpl7es8D/SlR ER8rBgwCrdEX9h1q2XgoRtWc+Ecf+Z+wcU6yOl1XTY8CvQDRham1/EebaL3U2mUziyoD Bdh3VqpZohiS/D6IkAZ00CPim3ZnBhoM1DJ+UaHPye72/tpHB+qXSsMjjcXkAhF4LeIa 8qPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J3GjYIYwifSay6HDg+VFEcdCVrSEjynp26pTorRquDM=; b=EwRZj5dO8JAETV0P+BeawV8JBUco0Zm4rLnuU9/P0UQdWVp2jI4MX9ka3rbXCzlRla mkLRO1vANxT2bAWseA/BKT9uRGuXHsqN35Cgbqirnwl05oIK7MS2Hlk96lx+QQJF4SvN X+9xgUyfgItiXc2hfnWtRQs3yn7UEnmeReBTxCnzmtdnxelhy4Z9V2UyvJfBr33AXCRs hMDCsmw9W4OLNdutGZ4A3q2JiBjRbP+vsTJgO+TrPobN4Zs7IHUVVcvEaX2AZC/ULZsr fZWwhkQImGn0DWuEBgC96METKl8QGStTYPtZ2gBTbvty87t5PtTBigbU7hEN3uz4wQDY xZ7A== X-Gm-Message-State: AJIora/bYyQr/EZjsa3Jbo61fU4jtRUhHEkR+ivVJ7tO/f5L8FUr6Wr4 2XaHE9c6RCO4WYT56frG1fb5arAI5CcQRw== X-Google-Smtp-Source: AGRyM1vJXfES8bwXpeQ5n3qKSUyf8sTtKItNUz3XosMj0IGEhhTYKGjLt3ySw4mpqE+8AuG/u/SKWQ== X-Received: by 2002:a05:6000:1a85:b0:21e:88f9:848d with SMTP id f5-20020a0560001a8500b0021e88f9848dmr12734495wry.82.1659009935662; Thu, 28 Jul 2022 05:05:35 -0700 (PDT) Received: from naush-laptop.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id e15-20020adfe7cf000000b0021e8d205705sm752995wrn.51.2022.07.28.05.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 05:05:35 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Thu, 28 Jul 2022 13:05:30 +0100 Message-Id: <20220728120530.4381-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220728120439.4109-1-naush@raspberrypi.com> References: <20220728120439.4109-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused Controller constructor X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The Controller(char const *jsonFilename) is not valid anymore since Controller::read() can now return an error on a failure. Additionally, this constructor is not actually used, so remove it. Signed-off-by: Naushir Patuck Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/controller/controller.cpp | 7 ------- src/ipa/raspberrypi/controller/controller.h | 1 - 2 files changed, 8 deletions(-) diff --git a/src/ipa/raspberrypi/controller/controller.cpp b/src/ipa/raspberrypi/controller/controller.cpp index bbd382bce3ab..f489278668ef 100644 --- a/src/ipa/raspberrypi/controller/controller.cpp +++ b/src/ipa/raspberrypi/controller/controller.cpp @@ -25,13 +25,6 @@ Controller::Controller() { } -Controller::Controller(char const *jsonFilename) - : switchModeCalled_(false) -{ - read(jsonFilename); - initialise(); -} - Controller::~Controller() {} int Controller::read(char const *filename) diff --git a/src/ipa/raspberrypi/controller/controller.h b/src/ipa/raspberrypi/controller/controller.h index 6be1e3cfa156..3e1e051703b3 100644 --- a/src/ipa/raspberrypi/controller/controller.h +++ b/src/ipa/raspberrypi/controller/controller.h @@ -40,7 +40,6 @@ class Controller { public: Controller(); - Controller(char const *jsonFilename); ~Controller(); int read(char const *filename); void initialise();