From patchwork Sun Jul 24 14:43:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 16752 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 45F86BE173 for ; Sun, 24 Jul 2022 14:44:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0FC256331B; Sun, 24 Jul 2022 16:44:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1658673854; bh=VGciOW5U+ee0LXxK1e5CjUkTEynElKoMA8UgLCPr2SE=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pV7jrjCFm7mC3MlfrZzcwPGoFpj5hUKNjY5+lukWlUcz6wv4+KcZtwEF3jXQCMo6m uI1Wr5zhxDvtjP/bhcqtTrlvhLpCTdWo0dC2iUlbAjvdqyLLY5206jldefl1Ow1xjT PvyXX56JWz7S2vToIQoxhHYJaL3WQVGnaEwtTlDxPO6PYCV7HZdD2xxZbTHjqJjaUJ LIlsybP2MzJwoszN+JIEbG14LcMRZyn0uwdfu2PSlioXRHfsQga6DP6Ji4Pq0+Str8 Ya10GiLiJKxSQs7YYWmVXzcBS0zsdhJxbH4yUm/zueoqdL5Hzer2nHGWiueuHN69rq nn+QdfWMq9jtw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DC6EB63315 for ; Sun, 24 Jul 2022 16:44:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="amz9E56N"; dkim-atps=neutral Received: from perceval.ideasonboard.com (unknown [IPv6:2401:4900:1f3e:f7a:bc8f:12ed:b45f:c35d]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4182C898; Sun, 24 Jul 2022 16:44:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1658673852; bh=VGciOW5U+ee0LXxK1e5CjUkTEynElKoMA8UgLCPr2SE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=amz9E56NxTkpkJ6dIjQebebYm+KU6klu3l+K48ddHxf2uP5n6SpxGjVyNgfW5hvP9 PyExr2aBs4Qi2zmQKO6IuJrGBbNHfL7BOCsaAdbS725vlGyqlWV+dLEXdc8yqkmt32 j8VVy+6WFaDr4mvRN/YTzqXDWF6aZKjQExCwzYvg= To: libcamera-devel@lists.libcamera.org Date: Sun, 24 Jul 2022 20:13:55 +0530 Message-Id: <20220724144355.104978-4-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220724144355.104978-1-umang.jain@ideasonboard.com> References: <20220724144355.104978-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/3] gstreamer: Provide colorimetry <> libcamera::ColorSpace mappings X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Cc: rishikeshdonadkar@gmail.com, nicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Rishikesh Donadkar Provide colorimetry <=> libcamera::ColorSpace mappings via: - GstVideoColorimetry colorimetry_from_colorspace(colorspace); - ColorSpace colorspace_from_colorimetry(colorimetry); Read the colorimetry field from caps into the stream configuration. After stream validation, the sensor supported colorimetry will be retrieved and the caps will be updated accordingly. Colorimetry support for gstlibcamerasrc currently undertakes only one argument. Multiple colorimetry support shall be introduced in subsequent commits. Signed-off-by: Rishikesh Donadkar Signed-off-by: Umang Jain --- src/gstreamer/gstlibcamera-utils.cpp | 175 +++++++++++++++++++++++++++ 1 file changed, 175 insertions(+) diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp index c97c0d43..fb4f0e5c 100644 --- a/src/gstreamer/gstlibcamera-utils.cpp +++ b/src/gstreamer/gstlibcamera-utils.cpp @@ -45,6 +45,157 @@ static struct { /* \todo NV42 is used in libcamera but is not mapped in GStreamer yet. */ }; +static GstVideoColorimetry +colorimetry_from_colorspace(const ColorSpace &colorSpace) +{ + GstVideoColorimetry colorimetry; + + switch (colorSpace.primaries) { + case ColorSpace::Primaries::Rec709: + colorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_BT709; + break; + case ColorSpace::Primaries::Rec2020: + colorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_BT2020; + break; + case ColorSpace::Primaries::Smpte170m: + colorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_SMPTE170M; + break; + default: + GST_WARNING("ColorSpace primaries not mapped in GstLibcameraSrc"); + colorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_UNKNOWN; + } + + switch (colorSpace.transferFunction) { + case ColorSpace::TransferFunction::Rec709: + colorimetry.transfer = GST_VIDEO_TRANSFER_BT709; + break; + case ColorSpace::TransferFunction::Srgb: + colorimetry.transfer = GST_VIDEO_TRANSFER_SRGB; + break; + case ColorSpace::TransferFunction::Linear: + colorimetry.transfer = GST_VIDEO_TRANSFER_GAMMA10; + break; + default: + GST_WARNING("ColorSpace transfer function not mapped in GstLibcameraSrc"); + colorimetry.transfer = GST_VIDEO_TRANSFER_UNKNOWN; + } + + switch (colorSpace.ycbcrEncoding) { + case ColorSpace::YcbcrEncoding::Rec709: + colorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT709; + break; + case ColorSpace::YcbcrEncoding::Rec2020: + colorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT2020; + break; + case ColorSpace::YcbcrEncoding::Rec601: + colorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT601; + break; + default: + GST_WARNING("Colorspace YcbcrEncoding not mapped in GstLibcameraSrc"); + colorimetry.matrix = GST_VIDEO_COLOR_MATRIX_UNKNOWN; + } + + switch (colorSpace.range) { + case ColorSpace::Range::Full: + colorimetry.range = GST_VIDEO_COLOR_RANGE_0_255; + break; + case ColorSpace::Range::Limited: + colorimetry.range = GST_VIDEO_COLOR_RANGE_16_235; + break; + default: + GST_WARNING("Colorspace range not mapped in GstLibcameraSrc"); + colorimetry.range = GST_VIDEO_COLOR_RANGE_UNKNOWN; + } + + return colorimetry; +} + +static std::optional +colorspace_from_colorimetry(GstVideoColorimetry *colorimetry) +{ + std::optional colorspace = ColorSpace::Default; + + switch (colorimetry->primaries) { + case GST_VIDEO_COLOR_PRIMARIES_BT709: + colorspace->primaries = ColorSpace::Primaries::Rec709; + break; + case GST_VIDEO_COLOR_PRIMARIES_BT2020: + colorspace->primaries = ColorSpace::Primaries::Rec2020; + break; + case GST_VIDEO_COLOR_PRIMARIES_SMPTE170M: + colorspace->primaries = ColorSpace::Primaries::Smpte170m; + break; + case GST_VIDEO_COLOR_PRIMARIES_UNKNOWN: + colorspace->primaries = ColorSpace::Primaries::Default; + break; + default: + GST_WARNING("Unknown primaries in colorimetry %d", colorimetry->primaries); + } + + switch (colorimetry->transfer) { + /* Tranfer function mappings inspired from v4l2src plugin */ + case GST_VIDEO_TRANSFER_GAMMA18: + case GST_VIDEO_TRANSFER_GAMMA20: + case GST_VIDEO_TRANSFER_GAMMA22: + case GST_VIDEO_TRANSFER_GAMMA28: + GST_WARNING("GAMMA 18, 20, 22, 28 transfer functions not supported"); + /* fallthrough */ + case GST_VIDEO_TRANSFER_GAMMA10: + colorspace->transferFunction = ColorSpace::TransferFunction::Linear; + break; + case GST_VIDEO_TRANSFER_BT601: + case GST_VIDEO_TRANSFER_BT2020_12: + case GST_VIDEO_TRANSFER_BT2020_10: + case GST_VIDEO_TRANSFER_BT709: + colorspace->transferFunction = ColorSpace::TransferFunction::Rec709; + break; + case GST_VIDEO_TRANSFER_SRGB: + colorspace->transferFunction = ColorSpace::TransferFunction::Srgb; + break; + case GST_VIDEO_TRANSFER_UNKNOWN: + colorspace->transferFunction = ColorSpace::TransferFunction::Default; + break; + default: + GST_WARNING("Unknown colorimetry transfer %d", colorimetry->transfer); + } + + switch (colorimetry->matrix) { + /* FCC is about the same as BT601 with less digit */ + case GST_VIDEO_COLOR_MATRIX_FCC: + case GST_VIDEO_COLOR_MATRIX_BT601: + colorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec601; + break; + case GST_VIDEO_COLOR_MATRIX_BT709: + colorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec709; + break; + case GST_VIDEO_COLOR_MATRIX_BT2020: + colorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec2020; + break; + case GST_VIDEO_COLOR_MATRIX_RGB: + case GST_VIDEO_COLOR_MATRIX_UNKNOWN: + colorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Default; + break; + default: + GST_WARNING("Unknown colorimetry matrix %d", colorimetry->matrix); + } + + switch (colorimetry->range) { + case GST_VIDEO_COLOR_RANGE_0_255: + colorspace->range = ColorSpace::Range::Full; + break; + case GST_VIDEO_COLOR_RANGE_16_235: + colorspace->range = ColorSpace::Range::Limited; + break; + case GST_VIDEO_COLOR_RANGE_UNKNOWN: + colorspace->range = ColorSpace::Range::Default; + break; + default: + GST_WARNING("Unknown range in colorimetry %d", colorimetry->range); + } + + return colorspace; +} + static GstVideoFormat pixel_format_to_gst_format(const PixelFormat &format) { @@ -139,6 +290,17 @@ gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg "width", G_TYPE_INT, stream_cfg.size.width, "height", G_TYPE_INT, stream_cfg.size.height, nullptr); + + if (stream_cfg.colorSpace) { + GstVideoColorimetry colorimetry = colorimetry_from_colorspace(stream_cfg.colorSpace.value()); + gchar *colorimetry_str = gst_video_colorimetry_to_string(&colorimetry); + + if (colorimetry_str != nullptr) + gst_structure_set(s, "colorimetry", G_TYPE_STRING, colorimetry_str, nullptr); + else + g_warning("libcamera::ColorSpace found but GstVideoColorimetry unknown"); + } + gst_caps_append_structure(caps, s); return caps; @@ -222,6 +384,19 @@ gst_libcamera_configure_stream_from_caps(StreamConfiguration &stream_cfg, gst_structure_get_int(s, "height", &height); stream_cfg.size.width = width; stream_cfg.size.height = height; + + /* Configure colorimetry */ + if (gst_structure_has_field(s, "colorimetry")) { + const gchar *colorimetry_caps = gst_structure_get_string(s, "colorimetry"); + GstVideoColorimetry colorimetry; + + if(gst_video_colorimetry_from_string(&colorimetry, colorimetry_caps)) { + std::optional colorSpace = colorspace_from_colorimetry(&colorimetry); + stream_cfg.colorSpace = colorSpace; + } else { + g_print("Invalid colorimetry %s", colorimetry_caps); + } + } } #if !GST_CHECK_VERSION(1, 17, 1)