From patchwork Thu Jul 21 13:45:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 16725 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C9F2FBE173 for ; Thu, 21 Jul 2022 13:45:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EEB606330F; Thu, 21 Jul 2022 15:45:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1658411142; bh=i+L6j3AdDpIeoMdta1mI0bprcF2kgfzQXMD0Z/TH1+c=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=P4IRP+6XHZIUIF6DAOVpjPGVwo9zQKLTcLsLz6bEzvPr8AQ++voo7tq8tEeqOrTaz DYbV818U5D8+nS+/cqPmSGazqu9urJWdLkgxQPFdZ6paSqpeqfThuIOx22duGSSnqz +0sLdl5wUiD4iBLhDBZPiFVAuvfcwbD0vqVBZLdKEIJj171gp8KeZ/GkzDteKk9AKZ 7rap5EOPwtnshXdBwMuE7siJb+XbCKiygTEqPV/z/SFVDCD4IvqPz6CP8SPO79iYiy EzDIMElZ0OtH4TS4me+SqcRnxNrqYialILI2qS4fBh/amEyw9rQCiMJQQaP6caupS9 ydq08Ab2w9rXQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EAA1601B8 for ; Thu, 21 Jul 2022 15:45:39 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="i8gz+92s"; dkim-atps=neutral Received: from perceval.ideasonboard.com (unknown [IPv6:2401:4900:1f3f:a2d:c6dd:7a7c:3d3c:dbb9]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A7AA496; Thu, 21 Jul 2022 15:45:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1658411139; bh=i+L6j3AdDpIeoMdta1mI0bprcF2kgfzQXMD0Z/TH1+c=; h=From:To:Cc:Subject:Date:From; b=i8gz+92s8QNf3IWC/rNDDM7CDtXShOELABPXErhs/5SkW+aOyR70WEEszhUJBPkLU ++b9eK1OO8Zud2J7CvBVnZSCriyYJRbvoLN75bA+rhVq2eSzgt9TPXa2ZbIfDs8d+H ySCDYI4XOaNr6k4smcdCXUrW15xDyYFInGYsuQOo= To: libcamera-devel@lists.libcamera.org Date: Thu, 21 Jul 2022 19:15:30 +0530 Message-Id: <20220721134531.1091104-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] test: gstreamer: Drop internal header from base class X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The internal header isn't needed. The needed function libcameraBuildPath() is exposed by libcamera/base/utils.h header. At the same time, move the utils header to .cpp instead of including it in the base class header itself. Signed-off-by: Umang Jain Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- test/gstreamer/gstreamer_test.cpp | 2 ++ test/gstreamer/gstreamer_test.h | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/test/gstreamer/gstreamer_test.cpp b/test/gstreamer/gstreamer_test.cpp index 227a5c37..cfb8afc6 100644 --- a/test/gstreamer/gstreamer_test.cpp +++ b/test/gstreamer/gstreamer_test.cpp @@ -5,6 +5,8 @@ * libcamera Gstreamer element API tests */ +#include + #include "gstreamer_test.h" #include "test.h" diff --git a/test/gstreamer/gstreamer_test.h b/test/gstreamer/gstreamer_test.h index 9869d252..35adab0e 100644 --- a/test/gstreamer/gstreamer_test.h +++ b/test/gstreamer/gstreamer_test.h @@ -10,10 +10,6 @@ #include #include -#include - -#include "libcamera/internal/source_paths.h" - #include class GstreamerTest