From patchwork Wed Jul 20 13:07:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 16704 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0E370BE173 for ; Wed, 20 Jul 2022 13:08:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8337263311; Wed, 20 Jul 2022 15:08:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1658322499; bh=SejG5UnOv2IuIsaxU1irfhGtnAyHlhAiEZRAYgV56bk=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=PFRlApAjII2kwKdQ290188lLeL1tCXy7iyp86iYdzPz9WgAdUHVKeNg1SE5w0Tlhi XdH4DWB8xP3Rju/JREa4GijvXqwSsC+4cs9/MvkIDnBTOSCmXgCbgAvKMMmOmIeG1W BevsG1AS3TUlBwEuiHOis2BnvLztOYb9KeDE3QGn0wtf8ulBW1cj9FeOg2ZDBuciEm dmZEU2g0DCMGhrOo3BeEDLHnBxTAwPvWVK+9T485rTsKmGpRljK8U5TyKfM5DBuJwc hDW9vZWKvZDpTF6srs/xLU5p9+izKbnQr7lwk6CewFkfTig+7T/0T56SMqOwU3v6c7 Bvwv+Noxm2efg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 25235601B8 for ; Wed, 20 Jul 2022 15:08:18 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="WcnaA7Vi"; dkim-atps=neutral Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 500A16DB; Wed, 20 Jul 2022 15:08:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1658322497; bh=SejG5UnOv2IuIsaxU1irfhGtnAyHlhAiEZRAYgV56bk=; h=From:To:Cc:Subject:Date:From; b=WcnaA7ViGIHygnQ+arhzlSR76nEL4Gvg2ZNAncaES8fEKi6JIKkDOMa/uDmHrwclu HYSeV5n26ALlMVFNtmdDYLoAcVutz6aoNlvCj66X6CJaApIFt/hkCH6iHs9dCgK849 IulD6a/ULyLsKcbubTl0pbMYOaTjZJDCU9VGpWho= To: libcamera-devel@lists.libcamera.org Date: Wed, 20 Jul 2022 16:07:40 +0300 Message-Id: <20220720130740.15300-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] ipa: rkisp1: Drop unnecessary forward declarations and includes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Forward declarations of IPACameraSensorInfo and inclusion of linux/rkisp1-config.h are not needed in headers that use them only for arguments to functions defined by the Algorithm base class, as inclusion of algorithm.h will bring the necessary declarations for function arguments. Drop them. Signed-off-by: Laurent Pinchart Reviewed-by: Florian Sylvestre Reviewed-by: Umang Jain --- src/ipa/rkisp1/algorithms/agc.h | 2 -- src/ipa/rkisp1/algorithms/awb.h | 2 -- src/ipa/rkisp1/algorithms/blc.h | 4 ---- 3 files changed, 8 deletions(-) base-commit: 8b02645845bf404fba83910818b285b652f14f89 diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h index 22c02779d311..1c9818b7db2a 100644 --- a/src/ipa/rkisp1/algorithms/agc.h +++ b/src/ipa/rkisp1/algorithms/agc.h @@ -17,8 +17,6 @@ namespace libcamera { -struct IPACameraSensorInfo; - namespace ipa::rkisp1::algorithms { class Agc : public Algorithm diff --git a/src/ipa/rkisp1/algorithms/awb.h b/src/ipa/rkisp1/algorithms/awb.h index 7647842f6609..667a8beb7689 100644 --- a/src/ipa/rkisp1/algorithms/awb.h +++ b/src/ipa/rkisp1/algorithms/awb.h @@ -7,8 +7,6 @@ #pragma once -#include - #include "algorithm.h" namespace libcamera { diff --git a/src/ipa/rkisp1/algorithms/blc.h b/src/ipa/rkisp1/algorithms/blc.h index c2649dd7736e..5fc3a80fb638 100644 --- a/src/ipa/rkisp1/algorithms/blc.h +++ b/src/ipa/rkisp1/algorithms/blc.h @@ -7,14 +7,10 @@ #pragma once -#include - #include "algorithm.h" namespace libcamera { -struct IPACameraSensorInfo; - namespace ipa::rkisp1::algorithms { class BlackLevelCorrection : public Algorithm