From patchwork Tue Jul 19 21:02:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 16693 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D4EBFBD1F1 for ; Tue, 19 Jul 2022 21:03:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8F8A963315; Tue, 19 Jul 2022 23:03:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1658264616; bh=8xIqQM5tBMEKVoJyB+lQ5aFpa0WhHh0Gy4HlsKsFCh4=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=PZ1uIgHYh+UARGU4iWJs4oEyAAqPfG7xdQbOE0ufnbiEAzwh3+OjCM4bI0WfdRV7s RWb3uJuEu1BNouZ3O6A+TRiCANDz7aFlI3iN+o4J7Lgjsp221gLWptspTXVwf3IQcK m3atNREdU2xqvHjLJfIlZGOmRrVtljfBK2soHpo7zOmAjvEXNMvj820o/ahBgkmI+0 bbHqy7ZNPgQvS329nsK+PQGNGEcfu1QS8UOUdjNRU6UuI7L9KPqelsyULJ1CBSVSCf 9EQlUE2TZotdJkA712Kx8e/YG5kMVDkjEWvD3HZda83k9C+bIzUsdRiMHkAAl0YKhX p86Dg13HkRBbA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 360C3603F4 for ; Tue, 19 Jul 2022 23:03:35 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="f1BlCl6s"; dkim-atps=neutral Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B4D866EE; Tue, 19 Jul 2022 23:03:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1658264614; bh=8xIqQM5tBMEKVoJyB+lQ5aFpa0WhHh0Gy4HlsKsFCh4=; h=From:To:Cc:Subject:Date:From; b=f1BlCl6sm1FuSDB39oa/z9T8W8byV1TNUXo/WTuzM7oRWim5/Xh5Ae9kfTlZG8gNP ZPcynXSHu3+oaxiKxiTMrxUiaDXhuL8qnppPB+f30kzDBKKl3eb6oxT0bW8LwgtNOR n+OAt/kZjAlXU8PRP83IO49LbEvZ8UCL4Z3T78Ls= To: libcamera-devel@lists.libcamera.org Date: Wed, 20 Jul 2022 00:02:57 +0300 Message-Id: <20220719210258.5602-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] licamera: controls: Drop unnecessary template qualifiers in documentation X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The doxygen document blocks of various ControlList function qualify functions with full template and return type specification. This isn't needed, and the extra verbosity makes the documentation blocks more difficult to read. Drop the template qualifiers and return types. The generated documentation is not affected. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Umang Jain --- src/libcamera/controls.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) base-commit: 62e32042aee4042b6a931bc27a6ad11384b521f5 diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp index 03ac6345247c..3fd535f204b2 100644 --- a/src/libcamera/controls.cpp +++ b/src/libcamera/controls.cpp @@ -954,7 +954,7 @@ bool ControlList::contains(unsigned int id) const } /** - * \fn template T ControlList::get(const Control &ctrl) const + * \fn ControlList::get(const Control &ctrl) const * \brief Get the value of control \a ctrl * \param[in] ctrl The control * @@ -969,7 +969,7 @@ bool ControlList::contains(unsigned int id) const */ /** - * \fn template void ControlList::set(const Control &ctrl, const V &value) + * \fn ControlList::set(const Control &ctrl, const V &value) * \brief Set the control \a ctrl value to \a value * \param[in] ctrl The control * \param[in] value The control value @@ -983,8 +983,7 @@ bool ControlList::contains(unsigned int id) const */ /** - * \fn template \ - * void ControlList::set(const Control &ctrl, const std::initializer_list &value) + * \fn ControlList::set(const Control &ctrl, const std::initializer_list &value) * \copydoc ControlList::set(const Control &ctrl, const V &value) */