From patchwork Mon Jul 18 11:51:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Curtin X-Patchwork-Id: 16676 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1C0C6BE173 for ; Mon, 18 Jul 2022 11:54:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7774A63312; Mon, 18 Jul 2022 13:54:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1658145257; bh=8ikKDZdNm1sMQsuvMyik1hVl0obCVDLUH5ZQHKRH2AU=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=RXSp/PBVvInnmyBzbNMi8+NPypVRP4wj0drpdDtRCcDoHZCOLEylAjERJlYZDGDlW ZFtr2QVcij0SvBO+YXIYW1QmlHNiJGlr8PKZeI3MDGts+/nMCQk/zyYARguuWKgAJz 2Gi4omvpLzZACCRee1W6AKLgqF9W66ZxXLrUsSjFub9kIg2CVudo+kpSoCnH9Ao7ut ygUaw/05SaucL7PesOIu6MdIMZb0pKGPsV/Vg6sx4F7rgAhMSkUyTSTMq5fQ5ORXCF pHk3CfQiwOq0J8kFsRbcy9uG9R3ziPLR3Dvz3VstUviN95oOep6D57GkDfkv/Zjr6o +Q/lA9iHm56uw== Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 77E4E6048B for ; Mon, 18 Jul 2022 13:54:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="P5BobyXa"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658145255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1CqFCwRwfGZ6wUjAuCgGdxoC1sKD43hr0CFFDVZlqTg=; b=P5BobyXaO1BcJzLbRQe8ZPOHTHCfcGtK1TaxL5VHoB1zCI3JT2gXK3tVY/UVeYMIfgoUDZ OpSayZi37lfaAwj0TR5X8g2yZOjxHm9LpD+DwdlN+twXlRLJ4+iXxz2OahKyHytWF1sOHp 0h6X7d5LUGt55PMpE92A/BmRJn7YQas= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-454-oPOeMLwoP7m_WIgQKnX9rQ-1; Mon, 18 Jul 2022 07:54:14 -0400 X-MC-Unique: oPOeMLwoP7m_WIgQKnX9rQ-1 Received: by mail-wr1-f70.google.com with SMTP id k26-20020adfb35a000000b0021d6c3b9363so1931589wrd.1 for ; Mon, 18 Jul 2022 04:54:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1CqFCwRwfGZ6wUjAuCgGdxoC1sKD43hr0CFFDVZlqTg=; b=FDSvRkDGZuPGr4eimTnnrMxRt1AOzbMlwovwV5pGO5B37D0tbQ+0DmrT/9JJ9sws6M hVWgtZGcVbw6kPxybpgq5Qet5TqU42zkW1/2QTW6zuifLdAuMPa1EMDiAWe4gh73cocZ g27GW1Mo9RbOCsRHHksauqTJsiPXc++AGDYCvBXv6iHRNz0Su/iU1Ux7C8CYrNQ7+Sav cxd+7w1/GtBkPt8STd8teSE3oBofyoPh0GqEOMIcOEio6jj8c58TF5prSkd3cG3bEdCy dzZayhblZVm6E5Oa9NEgkCDxBWl+dGz9SjOxR8ZgiO6tuQFFHAuYd/RwyX2KvIoGXC3Z cvBA== X-Gm-Message-State: AJIora/m/snCJU8gz6uFXfHCuuep7ugLafdYf2txQ7CGmhQSS1d6mtsN LrbWx5tZqHmEozt/2dqGdqTJ7aEL/Dgylb+dnP/0DXZ3wTSUobcedDDqJZDCG+gJ1PYm6TeIfqk pkBwq7khHAbHMeDDd/31FGrk0LcTPx4lAhzoq9l6t+P2J3ogtDwfqfxQX/juWNfvGaaHatPxyjy sX5hUz1pph X-Received: by 2002:a5d:5952:0:b0:21d:7c9b:e444 with SMTP id e18-20020a5d5952000000b0021d7c9be444mr22861355wri.75.1658145252940; Mon, 18 Jul 2022 04:54:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uKsa2epwXbNe7rSA2MNUXcH1uVlGae+IS1FfqZHRmPNO3W/B7adXsVVFfBHe5tRrPl+pLNuQ== X-Received: by 2002:a5d:5952:0:b0:21d:7c9b:e444 with SMTP id e18-20020a5d5952000000b0021d7c9be444mr22861328wri.75.1658145252576; Mon, 18 Jul 2022 04:54:12 -0700 (PDT) Received: from p1.Home ([2001:8a0:6724:4500:a69c:e66f:828e:b340]) by smtp.gmail.com with ESMTPSA id g20-20020a05600c4ed400b003a2cfb9f5basm21114471wmq.16.2022.07.18.04.54.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 04:54:12 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 18 Jul 2022 12:51:29 +0100 Message-Id: <20220718115128.22437-1-ecurtin@redhat.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ecurtin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [libcamera-devel] [PATCH v3] cam: sdl_sink: Use libjpeg over SDL2_image X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eric Curtin via libcamera-devel From: Eric Curtin Reply-To: Eric Curtin Cc: Ian Mullins , jozef@mlich.cz Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" We were using the libjpeg functionality of SDL2_image only, instead just use libjpeg directly to reduce our dependancy count, it is a more commonly available library. Signed-off-by: Eric Curtin --- Changes in v3: - create JpegErrorManager struct - change c cast to reinterpret_cast Changes in v2: - alphabetically sorted various orderings - pitch_ is const again - added setjmp logic for error handling in libjpeg - rgbdata_ to unique_ptr and renamed to rgb_ - removed a copy from buffer to rgb_ - removed a destructor --- README.rst | 2 +- src/cam/jpeg_error_manager.cpp | 26 ++++++++++++++++++++ src/cam/jpeg_error_manager.h | 21 ++++++++++++++++ src/cam/meson.build | 9 ++++--- src/cam/sdl_sink.cpp | 4 +-- src/cam/sdl_texture_mjpg.cpp | 45 +++++++++++++++++++++++++++++----- src/cam/sdl_texture_mjpg.h | 6 +++++ 7 files changed, 100 insertions(+), 13 deletions(-) create mode 100644 src/cam/jpeg_error_manager.cpp create mode 100644 src/cam/jpeg_error_manager.h diff --git a/README.rst b/README.rst index b9e72d81..47b914f0 100644 --- a/README.rst +++ b/README.rst @@ -92,8 +92,8 @@ for cam: [optional] tool: - libdrm-dev: Enables the KMS sink + - libjpeg-dev: Enables MJPEG on the SDL sink - libsdl2-dev: Enables the SDL sink - - libsdl2-image-dev: Supports MJPEG on the SDL sink for qcam: [optional] qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev diff --git a/src/cam/jpeg_error_manager.cpp b/src/cam/jpeg_error_manager.cpp new file mode 100644 index 00000000..7e45e577 --- /dev/null +++ b/src/cam/jpeg_error_manager.cpp @@ -0,0 +1,26 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (C) 2022, Ideas on Board Oy + * + * jpeg_error_manager.cpp - JPEG Error Manager + */ + +#include "jpeg_error_manager.h" + +static void errorExit(j_common_ptr cinfo) +{ + JpegErrorManager *self = + reinterpret_cast(cinfo->err); + longjmp(self->escape_, 1); +} + +static void outputMessage([[maybe_unused]] j_common_ptr cinfo) +{ +} + +JpegErrorManager::JpegErrorManager(struct jpeg_decompress_struct &cinfo) +{ + cinfo.err = jpeg_std_error(&errmgr_); + errmgr_.error_exit = errorExit; + errmgr_.output_message = outputMessage; +} diff --git a/src/cam/jpeg_error_manager.h b/src/cam/jpeg_error_manager.h new file mode 100644 index 00000000..0af28da1 --- /dev/null +++ b/src/cam/jpeg_error_manager.h @@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (C) 2022, Ideas on Board Oy + * + * jpeg_error_manager.h - JPEG Error Manager + */ + +#pragma once + +#include +#include + +#include + +struct JpegErrorManager { + JpegErrorManager(struct jpeg_decompress_struct &cinfo); + + /* Order very important for reinterpret_cast */ + struct jpeg_error_mgr errmgr_; + jmp_buf escape_; +}; diff --git a/src/cam/meson.build b/src/cam/meson.build index 5957ce14..86cef683 100644 --- a/src/cam/meson.build +++ b/src/cam/meson.build @@ -24,8 +24,8 @@ cam_sources = files([ cam_cpp_args = [] libdrm = dependency('libdrm', required : false) +libjpeg = dependency('libjpeg', required : false) libsdl2 = dependency('SDL2', required : false) -libsdl2_image = dependency('SDL2_image', required : false) if libdrm.found() cam_cpp_args += [ '-DHAVE_KMS' ] @@ -43,9 +43,10 @@ if libsdl2.found() 'sdl_texture_yuyv.cpp' ]) - if libsdl2_image.found() - cam_cpp_args += ['-DHAVE_SDL_IMAGE'] + if libjpeg.found() + cam_cpp_args += ['-DHAVE_LIBJPEG'] cam_sources += files([ + 'jpeg_error_manager.cpp', 'sdl_texture_mjpg.cpp' ]) endif @@ -57,8 +58,8 @@ cam = executable('cam', cam_sources, libcamera_public, libdrm, libevent, + libjpeg, libsdl2, - libsdl2_image, libyaml, ], cpp_args : cam_cpp_args, diff --git a/src/cam/sdl_sink.cpp b/src/cam/sdl_sink.cpp index f8e3e95d..19fdfd6d 100644 --- a/src/cam/sdl_sink.cpp +++ b/src/cam/sdl_sink.cpp @@ -21,7 +21,7 @@ #include "event_loop.h" #include "image.h" -#ifdef HAVE_SDL_IMAGE +#ifdef HAVE_LIBJPEG #include "sdl_texture_mjpg.h" #endif #include "sdl_texture_yuyv.h" @@ -62,7 +62,7 @@ int SDLSink::configure(const libcamera::CameraConfiguration &config) rect_.h = cfg.size.height; switch (cfg.pixelFormat) { -#ifdef HAVE_SDL_IMAGE +#ifdef HAVE_LIBJPEG case libcamera::formats::MJPEG: texture_ = std::make_unique(rect_); break; diff --git a/src/cam/sdl_texture_mjpg.cpp b/src/cam/sdl_texture_mjpg.cpp index 69e99ad3..e3fd1a35 100644 --- a/src/cam/sdl_texture_mjpg.cpp +++ b/src/cam/sdl_texture_mjpg.cpp @@ -7,19 +7,52 @@ #include "sdl_texture_mjpg.h" -#include +#include "jpeg_error_manager.h" + +#include using namespace libcamera; SDLTextureMJPG::SDLTextureMJPG(const SDL_Rect &rect) - : SDLTexture(rect, SDL_PIXELFORMAT_RGB24, 0) + : SDLTexture(rect, SDL_PIXELFORMAT_RGB24, rect.w * 3), + rgb_(std::make_unique(pitch_ * rect.h)) +{ +} + +int SDLTextureMJPG::decompress(const unsigned char *jpeg, + unsigned long jpeg_size) { + struct jpeg_decompress_struct cinfo; + JpegErrorManager jpegErrorManager(cinfo); + if (setjmp(jpegErrorManager.escape_)) { + /* libjpeg found an error */ + jpeg_destroy_decompress(&cinfo); + std::cerr << "JPEG decompression error" << std::endl; + return -EINVAL; + } + + jpeg_create_decompress(&cinfo); + + jpeg_mem_src(&cinfo, jpeg, jpeg_size); + + jpeg_read_header(&cinfo, TRUE); + + jpeg_start_decompress(&cinfo); + + for (int i = 0; cinfo.output_scanline < cinfo.output_height; ++i) { + JSAMPROW rowptr = rgb_.get() + i * pitch_; + jpeg_read_scanlines(&cinfo, &rowptr, 1); + } + + jpeg_finish_decompress(&cinfo); + + jpeg_destroy_decompress(&cinfo); + + return 0; } void SDLTextureMJPG::update(const Span &data) { - SDL_RWops *bufferStream = SDL_RWFromMem(data.data(), data.size()); - SDL_Surface *frame = IMG_Load_RW(bufferStream, 0); - SDL_UpdateTexture(ptr_, nullptr, frame->pixels, frame->pitch); - SDL_FreeSurface(frame); + decompress(data.data(), data.size()); + SDL_UpdateTexture(ptr_, nullptr, rgb_.get(), pitch_); } diff --git a/src/cam/sdl_texture_mjpg.h b/src/cam/sdl_texture_mjpg.h index b103f801..332c43d7 100644 --- a/src/cam/sdl_texture_mjpg.h +++ b/src/cam/sdl_texture_mjpg.h @@ -13,5 +13,11 @@ class SDLTextureMJPG : public SDLTexture { public: SDLTextureMJPG(const SDL_Rect &rect); + void update(const libcamera::Span &data) override; + +private: + int decompress(const unsigned char *jpeg, unsigned long jpeg_size); + + std::unique_ptr rgb_; };