From patchwork Fri Jul 15 14:38:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harvey Yang X-Patchwork-Id: 16648 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1AD14BE173 for ; Fri, 15 Jul 2022 14:38:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CB49863317; Fri, 15 Jul 2022 16:38:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1657895913; bh=urt/5C++X9cdIF0y+CArAknSIOV6BzGX19+GU7KvE08=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=zzi3EcroRp5FjYzpoaMNN+WB5tAJoDJp7vHLm9CLVnXk4E9ZEWo4XuxN4Zl8rAFC1 KU3d5FMhc9CT48v+rMUc0Dsh167T4ti1i7c72vdHT1ypOrkR8QjptHpbYaupskgbG4 P7eLmxYQ0Pp6z5kuxtH/nHKopqAU+dulg/UDZwSSIBTqvFWWxChoq9fZIQibj6SK6Y DEoPyVDyfRsheJB8sU2cWrCXJXxnj+SVz3+554YSAwTA2O7BeEDtHYCZEuwZp3dPF7 2UsRnP1LD50/ByLcB5toc+PyVLhJSRx3DIBvipUe23Ve4izMEfb0QU9+dBtoESw3dI PfNkZXLF/OgGQ== Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 336CC63314 for ; Fri, 15 Jul 2022 16:38:31 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="eLxXjw4B"; dkim-atps=neutral Received: by mail-pj1-x1031.google.com with SMTP id a15so5895386pjs.0 for ; Fri, 15 Jul 2022 07:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5IC4x1DsTIHmuTCSsPb9dfV0HTdarnfyKdb05Fd8Oy8=; b=eLxXjw4B4Ru6XPHLdjIsxF1Jb6kvB9f+k2VItrrxnteCseg4+BrDgF2sb1Rl64C02x 3xd8XnOBKh+Oq4uVSRuQ3FY5TYZGQqNp19dR/HoZYJFu9IzE17rMEhNZzPdRpeA/Yy+b Ez31Vsj8sDg9pftdZeEY0nDEa1XoM1KowTiGM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5IC4x1DsTIHmuTCSsPb9dfV0HTdarnfyKdb05Fd8Oy8=; b=HQT3kcIRXP549Q3RITFzpD68wF2Vo0Pe3uh+9gR76Dx1dAed9tX6v5I9yFNw77eoug foU1JNBJscd6SZuwMMfgWRZjG0kqNY2a91wfbMGmciTec+olN83NDuM6XYrOsnr4fcpv sO6XXz2eeIgSjEzwZl16383KC0CVlaKrkoWJgIJyMpTlBAgK900qoVIyy/G6vAGHdIUM jYOFI6HYgAL0uq7w59dC8/05xWtr4SCl9BGcCd9nUcdaw2n3Rjab4KX5FyA/fKKNXZd6 nQJhjyM2etSnyoRiXCDBvL9KZANLHY4JGx8sNRUQNfhdfeFIn5MllLDCG4gSFfFo2yCO xUAA== X-Gm-Message-State: AJIora8Sp0c18HMBth1VlQyy9uLkmliBoZ/jw4RVZfkpSOthJ/B0qItD +70JHKketah6Wmz3OZslVb1w5XBd6OObJQ== X-Google-Smtp-Source: AGRyM1vp0D+l2UsNgEXEbTStzUaUUakdpftCzw9LXjvHGFILoVMHCUDhSsR03xS7BjzQ4AcUwd1G+g== X-Received: by 2002:a17:90b:390a:b0:1f0:6a1a:9654 with SMTP id ob10-20020a17090b390a00b001f06a1a9654mr15987290pjb.90.1657895909334; Fri, 15 Jul 2022 07:38:29 -0700 (PDT) Received: from chenghaoyang-low.c.googlers.com.com (208.158.221.35.bc.googleusercontent.com. [35.221.158.208]) by smtp.gmail.com with ESMTPSA id f15-20020aa7968f000000b00528c22fbb45sm3972782pfk.141.2022.07.15.07.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 07:38:28 -0700 (PDT) X-Google-Original-From: Harvey Yang To: libcamera-devel@lists.libcamera.org Date: Fri, 15 Jul 2022 14:38:17 +0000 Message-Id: <20220715143822.672321-2-chenghaoyang@google.com> X-Mailer: git-send-email 2.37.0.170.g444d1eabd0-goog In-Reply-To: <20220715143822.672321-1-chenghaoyang@google.com> References: <20220715143822.672321-1-chenghaoyang@google.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v6 1/6] Allow inheritance of FrameBuffer X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harvey Yang via libcamera-devel From: Harvey Yang Reply-To: Harvey Yang Cc: Harvey Yang Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Harvey Yang To add buffer_handle_t access in android, this patch allows inheritance of FrameBuffer to add a derived class in android. Signed-off-by: Harvey Yang --- include/libcamera/framebuffer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h index 3b1118d1..e6c769b4 100644 --- a/include/libcamera/framebuffer.h +++ b/include/libcamera/framebuffer.h @@ -46,7 +46,7 @@ private: std::vector planes_; }; -class FrameBuffer final : public Extensible +class FrameBuffer : public Extensible { LIBCAMERA_DECLARE_PRIVATE() @@ -61,6 +61,7 @@ public: FrameBuffer(const std::vector &planes, unsigned int cookie = 0); FrameBuffer(std::unique_ptr d, const std::vector &planes, unsigned int cookie = 0); + virtual ~FrameBuffer() {} const std::vector &planes() const { return planes_; } Request *request() const;