From patchwork Thu Jul 7 15:03:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 16575 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BA1D5BD1F1 for ; Thu, 7 Jul 2022 15:03:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 73CA36331F; Thu, 7 Jul 2022 17:03:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1657206219; bh=wAvMxEfZn8715RVc8QhSgtUfojBsiCXx7C3tPNskzHs=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=3qKI79q9005Gt7VVSchAGxZAj6nkV+UYpPdGoUWCQ+FwYmypjwI7GGoRMOViAzBWG sclCcGr+KTGkflRJiKDolPeHjySkKuJfoVbZUHT6Z+f8GnKKPhUrgq1DmDh0+5OFxi npgJpTxho2ab0O48/S0GJ7XV1Tw3B9Xg/z8ysb9SCCzNAEe8O9o3EGiZInxtvSADjI Ja2bIuwqk8dEjggmYJrgSOK7EQ7KFyKHRYzkGYwUZv6jaosnVIs2CamJFdI7isI0OD nN3FXmUemsgjGdRdqIPZ70JZAX8pd8NOSNaFoALYhDw78aZX8uqvCjTJpoalKQwkKO WkjIXPH+aPd3w== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 50A296331B for ; Thu, 7 Jul 2022 17:03:38 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="uUNKU5iv"; dkim-atps=neutral Received: from pyrite.rasen.tech (softbank036240121080.bbtec.net [36.240.121.80]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 899766CA; Thu, 7 Jul 2022 17:03:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1657206217; bh=wAvMxEfZn8715RVc8QhSgtUfojBsiCXx7C3tPNskzHs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uUNKU5ivFZCASDrYAvL4evUD0FRbHLajMj85ehNESPtBt+NMJV64LVL0g6Uv8p06O /Ef3cfqwaSPsOYIRSQf/M2/+fHwK10Va1/b7Rg4IGF+s8OAlwVA294jTqSJye/Ojca 98uTU5dMue/OMpo6KZYqoSNf0GjOSZubNT5AEYfo= To: libcamera-devel@lists.libcamera.org Date: Fri, 8 Jul 2022 00:03:10 +0900 Message-Id: <20220707150310.3645858-5-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220707150310.3645858-1-paul.elder@ideasonboard.com> References: <20220707150310.3645858-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH 4/4] pipeline: rkisp1: Add support for UYVY X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Paul Elder via libcamera-devel From: Paul Elder Reply-To: Paul Elder Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Support for UYVY will be added soon in the rkisp1 driver. Add it to the pipeline handler to support it in libcamera as well. Signed-off-by: Paul Elder --- Besides the fact that support hasn't been merged (or sent yet, for that matter) in the rkisp1 driver, how do we deal with older versions of the driver that won't have UYVY support? Should we enumerate the formats and check if it's available? Just for UYVY or for all formats? --- src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp index 24ff62e1..6b4c4ed5 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp @@ -209,8 +209,9 @@ void RkISP1Path::stop() namespace { constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 }; constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 }; -constexpr std::array RKISP1_RSZ_MP_FORMATS{ +constexpr std::array RKISP1_RSZ_MP_FORMATS{ formats::YUYV, + formats::UYVY, formats::YUV420, formats::YVU420, formats::YUV422,