From patchwork Wed Jul 6 10:18:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 16563 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 80BA8BD1F1 for ; Wed, 6 Jul 2022 10:18:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7F26763313; Wed, 6 Jul 2022 12:18:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1657102725; bh=uyKuipDDdz/XZhk1uvlh59NH/oIDbLiIp/gjCbAu/q8=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=H8CZpkXfWsVPVUtRvdOUNDPSMR/ILlGWjlOOAM3zYJXy9cn7yUxJSdpDxkAS5xYt4 omjnoxKb+vYammX7URLB9E8cO4Yy//WJa44huyukQcMURchVEidgk0W1gfp50zpUfi KcEAbpUSMdb6exyTcWStERK4mUSkYUQdOtN02w389aUS/lnJ2S3CP7TvqHwqdhwEzr Y55VrlWymz2niuJyxYOLx6iGwhk6mpgO7aniAu8thWvfrcvU28RNLMWkb3BPj485yR mKFsPF1v8WXIOmUOq6jNIfg4srLqWzs5mFVEhjmlRehaZhzhFq5SkkGqcNJsJr2nIV n6CiWuZVj485Q== Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 836BD6330E for ; Wed, 6 Jul 2022 12:18:42 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="HpEQOljt"; dkim-atps=neutral Received: by mail-wr1-x430.google.com with SMTP id o4so21376613wrh.3 for ; Wed, 06 Jul 2022 03:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=TFoDYgGxHC/i4sL9ves7P72QTIn58Xk+z4xJBL6J09M=; b=HpEQOljtCgBhPkhwAAMgF8PL/bWj0mJ573Ccz/fSBlwGySb4YPyYm3DEWhhiiNauMz K4Ef58TTVvRyrp9oo8Gcz3bVgCWUKDvmFAO5w38aL2l+kgrFrxpN6B2p6ZIwnpW0Ta4+ FNh7kOR7A7s+zOXn618FQdffvCzvoc5ZwdDKxfqCMWSUxL6zFL9GE+hk6ad7Dd8U9Dcl sO9Lb5+HmpjJ4kdaM3EMXNSBXiXFhS8NlYGsR+tyoOert2BVdySY4XIUYrFLM9NRRiGo 7Fi+PazM7RJNnNmveKhH+EEWKyjURd0KYovu3ctg1+FeNecp5Fh9KqIDAssXlpbxIQio HUtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TFoDYgGxHC/i4sL9ves7P72QTIn58Xk+z4xJBL6J09M=; b=ViblyE37UU3Om9E28PqZw9IfQhFujcLvUXM2Z7Q+cuaje9w+1tN11+xo/LEN5BaACU AQTTGe9O5P2ATIT6nMC3972mUsDcHdVp3ZEKx+WIg2Msam9ZCY9lnHbhhGK/6ddQBh0w ctGTFi6iVi0bCY+1G0l+kogApLUDLKL+M8cjHM1S6DWknuvyVybqFUAJ2wev9Oo3qgMK 8KcuU/lSSTkKvx+K6A796vLD5hdp/Tnrfjm/gsx3CwADcK75f6NAu9EpABG2PwtXm+HQ eWQGRM7G/tp/NCnzuZ00oYmuW447Vp9e5IuxMHvYbNKCUdPGVYtYimZ9QoJXI/Fats7q mitA== X-Gm-Message-State: AJIora9vedaM813ECi+XaI77gm2aDMDyT/WARM4+3XPjU4BjeQsUNEsk 3ziep02OlYcqm+ZaKdt3F3chT+ZFCii/sw== X-Google-Smtp-Source: AGRyM1s+0ZyrFZcY8AvxCpHkb9zMKH6dlrusrIbePVpZDz7hxoJ8WoNznieEslU3v8i3mfEqQ/6TBw== X-Received: by 2002:a05:6000:1a87:b0:21c:65c8:2d8 with SMTP id f7-20020a0560001a8700b0021c65c802d8mr37604684wry.370.1657102721991; Wed, 06 Jul 2022 03:18:41 -0700 (PDT) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id i1-20020adffc01000000b0021b5861eaf7sm35950820wrr.3.2022.07.06.03.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 03:18:41 -0700 (PDT) To: libcamera-devel@lists.libcamera.org, william.vinnicombe@raspberrypi.com Date: Wed, 6 Jul 2022 11:18:35 +0100 Message-Id: <20220706101836.20153-3-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220706101836.20153-1-david.plowman@raspberrypi.com> References: <20220706101836.20153-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/3] utils: raspberrypi: ctt: Add alsc_only method X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: William Vinnicombe The ctt would not work if only passed alsc images. Added alsc_only.py to run alsc calibration only, and modified check_imgs to allow for no macbeth chart images. Example usage would be ./alsc_only.py -i tuning-images/ -o sensor.json with the same optional arguments as the original ctt. Signed-off-by: William Vinnicombe Reviewed-by: David Plowman Reviewed-by: Naushir Patuck --- utils/raspberrypi/ctt/alsc_only.py | 118 +++++++++++++++++++++++++++++ utils/raspberrypi/ctt/ctt.py | 8 +- 2 files changed, 124 insertions(+), 2 deletions(-) create mode 100755 utils/raspberrypi/ctt/alsc_only.py diff --git a/utils/raspberrypi/ctt/alsc_only.py b/utils/raspberrypi/ctt/alsc_only.py new file mode 100755 index 00000000..318adc8c --- /dev/null +++ b/utils/raspberrypi/ctt/alsc_only.py @@ -0,0 +1,118 @@ +#!/usr/bin/env python3 +# +# SPDX-License-Identifier: BSD-2-Clause +# +# Copyright (C) 2022, Raspberry Pi (Trading) Limited +# +# alsc_only.py - alsc tuning tool + +from ctt import * + + +def run_alsc(json_output, directory, config, log_output): + """ + check input files are jsons + """ + if json_output[-5:] != '.json': + raise ArgError('\n\nError: Output must be a json file!') + if config is not None: + """ + check if config file is actually a json + """ + if config[-5:] != '.json': + raise ArgError('\n\nError: Config file must be a json file!') + """ + read configurations + """ + try: + with open(config, 'r') as config_json: + configs = json.load(config_json) + except FileNotFoundError: + configs = {} + config = False + except json.decoder.JSONDecodeError: + configs = {} + config = True + + else: + configs = {} + """ + load configurations from config file, if not given then set default + only load configurations needed for alsc, and directly define others + """ + plot = get_config(configs, "plot", [], 'list') + alsc_d = get_config(configs, "alsc", {}, 'dict') + do_alsc_colour = get_config(alsc_d, "do_alsc_colour", 1, 'bool') + luminance_strength = get_config(alsc_d, "luminance_strength", 0.5, 'num') + blacklevel = get_config(configs, "blacklevel", -1, 'num') + mac_config = (0, 0) + + if blacklevel < -1 or blacklevel >= 2**16: + print('\nInvalid blacklevel, defaulted to 64') + blacklevel = -1 + + if luminance_strength < 0 or luminance_strength > 1: + print('\nInvalid luminance_strength strength, defaulted to 0.5') + luminance_strength = 0.5 + + """ + sanitise directory path + """ + if directory[-1] != '/': + directory += '/' + """ + initialise tuning tool and load images + """ + try: + Cam = Camera(json_output) + Cam.log_user_input(json_output, directory, config, log_output) + disable = set(Cam.json.keys()).symmetric_difference({"rpi.alsc"}) + Cam.disable = disable + Cam.plot = plot + Cam.add_imgs(directory, mac_config, blacklevel) + except FileNotFoundError: + raise ArgError('\n\nError: Input image directory not found!') + + """ + preform calibrations as long as check_imgs returns True + Only performs the alsc calibration + """ + if Cam.check_imgs(macbeth=False): + Cam.json_remove(disable) + print('\nSTARTING CALIBRATIONS') + Cam.alsc_cal(luminance_strength, do_alsc_colour) + print('\nFINISHED CALIBRATIONS') + Cam.write_json() + Cam.write_log(log_output) + print('\nCalibrations written to: '+json_output) + if log_output is None: + log_output = 'ctt_log.txt' + print('Log file written to: '+log_output) + pass + else: + Cam.write_log(log_output) + + +if __name__ == '__main__': + """ + initialise calibration + """ + if len(sys.argv) == 1: + print(""" + Pisp Camera Tuning Tool version 1.0 + + Required Arguments: + '-i' : Calibration image directory. + '-o' : Name of output json file. + + Optional Arguments: + '-c' : Config file for the CTT. If not passed, default parameters used. + '-l' : Name of output log file. If not passed, 'ctt_log.txt' used. + """) + quit(0) + else: + """ + parse input arguments + """ + json_output, directory, config, log_output = parse_input() + run_alsc(json_output, directory, config, log_output) diff --git a/utils/raspberrypi/ctt/ctt.py b/utils/raspberrypi/ctt/ctt.py index 15064634..0ea4854d 100755 --- a/utils/raspberrypi/ctt/ctt.py +++ b/utils/raspberrypi/ctt/ctt.py @@ -664,7 +664,7 @@ class Camera: - incorrect filename/extension - images from different cameras """ - def check_imgs(self): + def check_imgs(self, macbeth=True): self.log += '\n\nImages found:' self.log += '\nMacbeth : {}'.format(len(self.imgs)) self.log += '\nALSC : {} '.format(len(self.imgs_alsc)) @@ -672,10 +672,14 @@ class Camera: """ check usable images found """ - if len(self.imgs) == 0: + if len(self.imgs) == 0 and macbeth: print('\nERROR: No usable macbeth chart images found') self.log += '\nERROR: No usable macbeth chart images found' return 0 + elif len(self.imgs) == 0 and len(self.imgs_alsc) == 0: + print('\nERROR: No usable images found') + self.log += '\nERROR: No usable images found' + return 0 """ Double check that every image has come from the same camera... """