From patchwork Mon Jul 4 23:32:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 16539 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A6C0DBE173 for ; Mon, 4 Jul 2022 23:32:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1CBA263318; Tue, 5 Jul 2022 01:32:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1656977557; bh=/16NRmqVAVwDPoEee56Lymj5hfeWnsuaNzk+/jfYIM4=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=eTC4OYnqtGhahdcUaNS5pcDqIu4BE+KrBnR5T/G5WwOtve+FnEBnkgqaswe2H2gml azrQzxuCBftr9O6bJJykFv9wnbUpYyaYc4BONz6mnBo8gEb3R111qYOVZOaEIpdy8u yGQo0Sxx6ciREM04RArJt6JtVes8gpO1MbZ3yrOOinvIRsB6WR1jb+N6KVepucaan/ OUmRRCt0eV7JhfhrVMGCNbSzVZ4tzMvQaGz/ylXvk8NzTkUzkXltl241nCxTg4ysq0 NKdM8+4/h/KReWTezTM2TaxYR+BsrP8xLv768THQDjN7hP3+F+1t2vxUkSI5vDqEWn uL1fqaWiYdswQ== Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C3946330E for ; Tue, 5 Jul 2022 01:32:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="a1aygOr9"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1656977553; bh=/16NRmqVAVwDPoEee56Lymj5hfeWnsuaNzk+/jfYIM4=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=a1aygOr9ON1onlLPVB40B6w9/thWIS36ec9754wvCXJ15JR9CzMMQns05wYqWZnyV dti4TGuvn2iWvZCV3cq9WpVcTIh2kZr1qeYTT076+c0lL0+L68YXjFQSrrtgvzoYXr bcVVRLxe6LD5fgt8cIYUkNciV5KO9idwXY4Onkb0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([92.18.80.244]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MuDc7-1nKnka2PIT-00ub2R; Tue, 05 Jul 2022 01:32:33 +0200 To: libcamera-devel@lists.libcamera.org Date: Tue, 5 Jul 2022 00:32:15 +0100 Message-Id: <20220704233217.54769-3-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220704233217.54769-1-Rauch.Christian@gmx.de> References: <20220704233217.54769-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:/2oK35LtBlWFHPeYeZOs3cTRQzzu5SgZ6QNVE5eJwsLoO1CHLIY Dw5EyIt9DCyEK0TLp4JfXuKKg2qk534NwHGJix/ZpGTmV+SqC4huPD8uV30kwyJ07eKhORq 6YMplxoYTzCAhy+R4Yunl07HOh1Jup/0wGAhp6CuiIS4BG40tNyjii0glnSMrQUwPNeCkNm Exyg7frAN8K7Xm89qcUlA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:nv1wakTSGek=:4P4G1Oe66wajjOpP0TNs53 K0QqAUzlMcUtmwsJvJ8DPPDSEQHygIxiZMAm+iZrsKKggPfmZ9Bt8fUvF0/NS9BKjqZL7OiCm 6czCfik9aiIKdcsOberq0eC0HYBdHk6efL4PzxOCR2OYx9MMmdOVcvtHBmihNm7Qi2vvzVsQo V0W1uQvvOm9T0tq4DkXum2cMXnabYEVcl06gGEWMyYuGZ5pG4GnwJ4XKXwQhuHwTcxVPbfz0H nkvkWm7k1yU4xeRO2Kp6hTpua5sk8q04bAdKPG4AG725fQMAIU+tI3lIC8wdPxPCKIhiOgDtB XZATrKoF/czyaFDRKosEXmsRGHuvloDpknLbOGTsZPr14rur2fnQBxmvREJL6KDTSRfVsIvp1 KgMN4ufnkJCuoN96ITK06Qxfa5vq5wpuY/kp9TZmqNH55yv8bIkDriApZ/zGVd9HYNwcQHVzY vjeIVr4yS/tzJYSaoA2HrokMOQM1YyarC3VjxXL//NfY2JqQlZLlicgsJwOfEgOPt8Eia6nUX yEtga40i3KVyhHNOrcJpQVvQH7y25x2qAM4v4Ng8vrQnxfFCWF0BumsSLGjU/fnjMbQEWf5St t5B5hLtbrX57ksmV+frlR6Mhc8Kd7n6r9P1njq5PfcGKA04Cda3ZiG1xz9sIIyy3k+c2qogNU VWjGD9bb2BtsfHaM36Um4XSU7JduDmMjrmjHzVfv8qdr06AfQQsFDrSeBmaKlFnrUnwYX8u7C 5d116gdwJWRk3ONgLKXpMbO1xvFgKse873oEdKMhrTWJwWfCSsTgHzpVAQgcNX4r6u1uJYO4D sVn7mi0BW6Bx4pob0g31RUKJGS0D6eS7vn84Q28IFhG5Dazmi3FRUlme7fX1tsdmV6UroNqZv eAFSywMoLslS/BLhDnX6Ae4VXFWuU+XRdIyThbNnWFNmCoTl1qi+MM2Cu2+xcZ00BDVBrNo5l fYlKzDtf7wWfpAVAZELRmp1D1/RRX1w83jIBBPT8CVE12kuBsW7GAaWgOfDbWu9l2mjLWpOuF FJArbXajvoyujTGb9gzaP4sUxmW6eKaRsdday0GWkW/ZjNCv/TDvYQRwCPzPzL4RGZvdrG9cp x/zmoRSyJwl7JOkyw28q6iEfpqYDboywL/ElGRTqwjh2qt4Xn3gQECRCw== Subject: [libcamera-devel] [PATCH v9 2/4] libcamera: controls: Define size of array controls as a shape vector X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This follows the convention in other Tensor APIs. Since all tensors are represented as a Span with a single dimension, values provided in 'size' are interpreted as fixed-size Spans, while an empty array ("[]") will be interpreted as variable-sized Span. Signed-off-by: Christian Rauch Reviewed-by: Jacopo Mondi --- src/libcamera/control_ids.yaml | 4 ++-- src/libcamera/property_ids.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.34.1 diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index ecab3ae9..5fa168c6 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -291,7 +291,7 @@ controls: transformation. The 3x3 matrix is stored in conventional reading order in an array of 9 floating point values. - size: [3x3] + size: [3,3] - ScalerCrop: type: Rectangle @@ -525,7 +525,7 @@ controls: the window where the focal distance for the objects shown in that part of the image are closest to the camera. - size: [n] + size: [] - AfTrigger: type: int32_t diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml index 11b7ebdc..a87485d7 100644 --- a/src/libcamera/property_ids.yaml +++ b/src/libcamera/property_ids.yaml @@ -497,7 +497,7 @@ controls: - PixelArrayOpticalBlackRectangles: type: Rectangle - size: [n] + size: [] description: | The pixel array region(s) which contain optical black pixels considered valid for calibration purposes. @@ -592,7 +592,7 @@ controls: - PixelArrayActiveAreas: type: Rectangle - size: [n] + size: [] description: | The PixelArrayActiveAreas property defines the (possibly multiple and overlapping) portions of the camera sensor readable pixel matrix