From patchwork Fri Jul 1 08:45:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 16493 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7D50EBD808 for ; Fri, 1 Jul 2022 08:45:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7FE976564E; Fri, 1 Jul 2022 10:45:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1656665143; bh=kAL85UrCX4ZS6H5jh0S4WDQbWuTWODAQW0q+OmJ+1ng=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=P+ogX+xQH6TFxAd3rWOBaFnrIR3x4KjzQ/M6dZpnMDqSWnxqB+0SWkrL+Sxy99wew P51PycKRi2G1/ZI6waptUTIaeGpKggKBHcitw4gA4yhwYTibD5Q1Hz76olf1s3vWDu M6ffru9Z7XLLtpB/UoRKslCGtM8RGC0kZ77Sdx6xo2OQWuBO93mtDjWT13jS4Duz+N Hhl5fYtYnB+fFdHmQ00kxeQtZ2Hq+6vd+qNWBubX/uu9Hr0BBHD9+GSR0f8InPQMw9 NFEIwjp9LZ9CipikJ4o8P/4hEkG6MoVbDiBWrnZvu5kk3903/prgwZceP6kgKh0ZvK qB+FVvDWRiBEA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 69F9D6564B for ; Fri, 1 Jul 2022 10:45:41 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sjXw6RLy"; dkim-atps=neutral Received: from deskari.lan (91-158-154-79.elisa-laajakaista.fi [91.158.154.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B20546BB; Fri, 1 Jul 2022 10:45:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1656665141; bh=kAL85UrCX4ZS6H5jh0S4WDQbWuTWODAQW0q+OmJ+1ng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sjXw6RLya9MXj3WC1tEdKSN5wOdK893QoUKf0ndS7pBZeSIVWX7HgM1xzdHNUWZJ1 etx8BWDDVRCVh17SJuld0u22aZJNVseKhrsddKgYGlpdWcmD0dxJrrrtJd/SMUp6CD fRTJy5XcLRJ6GwZiJRcbIpe0OASt+rzaXiO1Sf60= To: libcamera-devel@lists.libcamera.org, David Plowman , Kieran Bingham , Laurent Pinchart , Jacopo Mondi Date: Fri, 1 Jul 2022 11:45:05 +0300 Message-Id: <20220701084521.31831-2-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220701084521.31831-1-tomi.valkeinen@ideasonboard.com> References: <20220701084521.31831-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 01/17] py: cam.py: Fix multi camera capture without -C X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tomi Valkeinen via libcamera-devel From: Tomi Valkeinen Reply-To: Tomi Valkeinen Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" -C flag is supposed to affect only the camera that was previously defined in the arguments. That's not the case, and, e.g.: cam.py -c2 -C -c3 causes camera 3 to start capturing, but it stops after the initial Requests have been completed. Fix the issue by filtering out camera contexts that do not have -C defined. Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/py/cam/cam.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py index 2ae89fa8..8a82e092 100755 --- a/src/py/cam/cam.py +++ b/src/py/cam/cam.py @@ -434,7 +434,10 @@ def main(): if args.info: ctx.do_cmd_info() - if args.capture: + # Filter out capture contexts which are not marked for capture + contexts = [ctx for ctx in contexts if ctx.opt_capture > 0] + + if contexts: state = CaptureState(cm, contexts) if args.renderer == 'null':