From patchwork Thu Jun 23 23:22:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 16351 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A3365BD808 for ; Thu, 23 Jun 2022 23:22:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 451C665651; Fri, 24 Jun 2022 01:22:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1656026559; bh=ppGZ8deBlgpt1OXy2Tb99DwXpDsPR0U5NBjBV5Lby2U=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RbILLX4Ae3LAhiTkpeVBhMQLFg35BC93hIKiRcLJje9M0N6CjOpG7Qugpk85H30iC XoB+cz6Ak8u8bExJ3D9Tv7D8df8eC1oxCi7EHuOS4Nx3/ggoR9XZH4O3NwZ/diD6kx bPBZ3SPaeT0mb3gR6rmTTfmcF/Hc8pWeowGFanIIqv19D3eGheGWzL7qYgkr5DNQhW AnuX0che6rjd7Sz8ofUmP15HTuBtONPel3BTvmu/nE0M80jLJvZtP7KpiK3ShYZAwX dV1UZHF8hCnstHGkutlDnRGzNmgxg1YtkcaULzG7cOFNiwwnAZlNxIfdM6/tvjSH/I Ytf92fvquAtZg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A0F065641 for ; Fri, 24 Jun 2022 01:22:31 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="cfiKYLh2"; dkim-atps=neutral Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 22693DD; Fri, 24 Jun 2022 01:22:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1656026551; bh=ppGZ8deBlgpt1OXy2Tb99DwXpDsPR0U5NBjBV5Lby2U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cfiKYLh2BcKdhqPHkAtHrKFluEFOB3P3393ljDLZKChyxn71DjZ9ZKAlKhOc9oBtg AJfntpoDD5H9Dy/uKMbbBrnNdZ8c+3rHnT77vZ4td1h+5aBz0yS+rrolBv1Q12pobN 0scBhhZ9jnLYyUFRWW3SHLGi+xndzKaj7TmSm/JQ= To: libcamera-devel@lists.libcamera.org Date: Fri, 24 Jun 2022 02:22:03 +0300 Message-Id: <20220623232210.18742-7-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220623232210.18742-1-laurent.pinchart@ideasonboard.com> References: <20220623232210.18742-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 06/13] gstreamer: Rename queued requests queue to queuedRequests_ X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Cc: Nicolas Dufresne , Vedant Paranjape Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" To prepare for the addition of a completed requests queue, rename the existing queued requests queue from requests_ to queuedRequests_. Signed-off-by: Laurent Pinchart Reviewed-by: Nicolas Dufresne Reviewed-by: Umang Jain --- src/gstreamer/gstlibcamerasrc.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index a1fab71d4f09..02fc913764f8 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -108,7 +108,7 @@ struct GstLibcameraSrcState { std::shared_ptr cam_; std::unique_ptr config_; std::vector srcpads_; - std::queue> requests_; + std::queue> queuedRequests_; guint group_id_; void requestCompleted(Request *request); @@ -155,8 +155,8 @@ GstLibcameraSrcState::requestCompleted(Request *request) GST_DEBUG_OBJECT(src_, "buffers are ready"); - std::unique_ptr wrap = std::move(requests_.front()); - requests_.pop(); + std::unique_ptr wrap = std::move(queuedRequests_.front()); + queuedRequests_.pop(); g_return_if_fail(wrap->request_.get() == request); @@ -311,7 +311,7 @@ gst_libcamera_src_task_run(gpointer user_data) GLibLocker lock(GST_OBJECT(self)); GST_TRACE_OBJECT(self, "Requesting buffers"); state->cam_->queueRequest(wrap->request_.get()); - state->requests_.push(std::move(wrap)); + state->queuedRequests_.push(std::move(wrap)); /* The RequestWrap will be deleted in the completion handler. */ }