From patchwork Mon Jun 20 05:11:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 16283 X-Patchwork-Delegate: umang.jain@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CAB6CBD808 for ; Mon, 20 Jun 2022 05:12:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D290665633; Mon, 20 Jun 2022 07:12:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1655701921; bh=9/hFVqkt/YUAhJphnv1ZcydS9lVQQoFh/Sbp5l0JE08=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ZPKIx+3dIb20JAUV0jxaJXz2F8ICRriFy0TtKsQ/9x+7FIsOBp1rG/kVlj6m+NrAl HvfrrgtmrC974GXGgqB7yAsPqbPzc6WCMNQO3fym4R5FeC554hkVbphB5C0cr1aPZX O/Ttq1hq5HUyj0obQbo1m4kkroFCYoEGAhUkJohxmcFi30NueXlCTMUcLmx57HUsS5 T12O1xBFJAvjMyZeq16l/+0arq+7rov08BJUQScn8kO3eyYjjGQY4FdDFozjluVtMD Z5+YRLwUJHfM41wsd/lo2f1IdONFinqW7NzQTzTtQjYFKL1btfU2QafHuN+IEEub/X j/xy8lOmdYmwA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C3FDC6048F for ; Mon, 20 Jun 2022 07:11:59 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="r58JbEd7"; dkim-atps=neutral Received: from perceval.ideasonboard.com (unknown [IPv6:2401:4900:1f3f:e389:cb58:4104:f66:a571]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 04CDD892; Mon, 20 Jun 2022 07:11:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1655701919; bh=9/hFVqkt/YUAhJphnv1ZcydS9lVQQoFh/Sbp5l0JE08=; h=From:To:Cc:Subject:Date:From; b=r58JbEd7XZTTE+u7svfdDV3lXLLHui+CryzeyUi28Eioo3pcVGWURirnWkvkRFYXg ioF+COhSjW4XfwgFG17VY4JsHK9bRC7LG9q9H09M/tw0JLIDntBZqRKtbLf4bDwzFc Gj158CQUukhIQ5MOUl0XA3EogvqGUsKbZIKyQ3Pk= To: libcamera-devel@lists.libcamera.org Date: Mon, 20 Jun 2022 10:41:50 +0530 Message-Id: <20220620051150.361575-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: base: thread: Protect exitCode by mutex in exit() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Hirokazu Honda Thread::exit() accesses data_->exitCode without acquiring a lock. Fix it. Signed-off-by: Hirokazu Honda Signed-off-by: Umang Jain --- src/libcamera/base/thread.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp index 6bda9d14..ff65641e 100644 --- a/src/libcamera/base/thread.cpp +++ b/src/libcamera/base/thread.cpp @@ -392,7 +392,10 @@ void Thread::finishThread() */ void Thread::exit(int code) { + data_->mutex_.lock(); data_->exitCode_ = code; + data_->mutex_.unlock(); + data_->exit_.store(true, std::memory_order_release); EventDispatcher *dispatcher = data_->dispatcher_.load(std::memory_order_relaxed);