From patchwork Sun Jun 12 15:23:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 16198 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7846CC3273 for ; Sun, 12 Jun 2022 15:23:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 944FC6563B; Sun, 12 Jun 2022 17:23:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1655047405; bh=VyiVX0meUYlRNfln26J7Lo+8p7G4tVTwjxezjqGQMdc=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=kd/8CQc67/Q6CiAcddELdhoyHdzg3GAVKhisQ5k+qHf9foTFUANdCPY09YF0FSbWn 9i8FP3nsB+y50KEpHbNWG4hpdQajOvqi3q9SFCP0AMYKYglrlThZDeFyiti8JwW4K3 BlrYat60C62u/nxPkSCbeLyuJyuBo526CWffE19yXzZ+zmMFm/w+RniwSrMu9OH1/W 7nL9SYa7RCa3iqM25T+bDSQ1yjPdTU+loEF8syaEt+WmGvCGXtkPVl1MkukW/hyEYU gLE4W837Yb8/rGi+hJiYxUSyLuFNYTvBWqMANxMQgjln6H6mt0Tt/Hef9VDZFYK5n5 hiWAoOnQE3RPw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5412D600F4 for ; Sun, 12 Jun 2022 17:23:24 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="stO5Ekg1"; dkim-atps=neutral Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B9083825; Sun, 12 Jun 2022 17:23:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1655047404; bh=VyiVX0meUYlRNfln26J7Lo+8p7G4tVTwjxezjqGQMdc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=stO5Ekg1OIP/nxqJC3MkLWywuCWJJsj1TYfvOWXckk0oDHecf1HMF/ZaLCvGbDhM1 YMigVGn7t4IQNDgMwQMxvL91Bwb4WrOKnzP2jfF9aOCo4N42iXerJRFqWtYhb0nJXa LBy0v5cycDFQuRL4PHH07kqSZzlr69ZMimBTjiAk= To: libcamera-devel@lists.libcamera.org Date: Sun, 12 Jun 2022 18:23:07 +0300 Message-Id: <20220612152311.8408-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220612152311.8408-1-laurent.pinchart@ideasonboard.com> References: <20220612152311.8408-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/5] libcamera: pipeline: simple: Improve debug message on config failure X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Cc: Dorota Czaplejewicz , Benjamin Schaaf Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When pipeline configuration fails, print the format returned by the kernel in addition to the one requested by libcamera, to ease debugging. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/libcamera/pipeline/simple/simple.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index de75465eb3b5..efb28ccd97e8 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -939,7 +939,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c) captureFormat.size != pipeConfig->captureSize) { LOG(SimplePipeline, Error) << "Unable to configure capture in " - << pipeConfig->captureSize << "-" << videoFormat; + << pipeConfig->captureSize << "-" << videoFormat + << " (got " << captureFormat << ")"; return -EINVAL; }