From patchwork Sat Jun 4 09:30:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 16154 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 90F51BD161 for ; Sat, 4 Jun 2022 09:30:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0A10865644; Sat, 4 Jun 2022 11:30:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1654335041; bh=EiwsPOXrJuNiFDEXHo+ormYGtZs8Ma1ZJCfkXtU6hWA=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ZZf1hmdS2DAqVKX5LMcp8YDQ9Pd5SCEbZtmVoduj4axup/OciVV+CvBK0h94hrc47 MQg9UXeu7XQPJ/5c3qJVzU+JRmCrXlY/Owr7V+6W/IfUZgtIiRRkBR0ai3YcxDFOG6 wswVCzSNBqaDvJ/O1LTGZbV5PwWl3nyoYH766yxYPIRPD9JxaYAo97asaZi5obvQIn dSWYKTtOlESgzGELjXfHaWOPzGLvFr1TSWT33Qhh3ANXmPXKnRMLj5xOCK8D57wiK0 G07VyX9dw4uAZv1txVB7BBDMxdlb3TK6ehlLhJTR388kAJDvMaC7sdh9Oimb4wmtAU 6G3ukgeTTt6HQ== Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id ACC4E65644 for ; Sat, 4 Jun 2022 11:30:38 +0200 (CEST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id 5C8C7E000A; Sat, 4 Jun 2022 09:30:37 +0000 (UTC) To: libcamera-devel@lists.libcamera.org Date: Sat, 4 Jun 2022 11:30:25 +0200 Message-Id: <20220604093025.77737-6-jacopo@jmondi.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220604093025.77737-1-jacopo@jmondi.org> References: <20220604093025.77737-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 5/5] android: camera_device: Print the correct number of completed streams X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jacopo Mondi via libcamera-devel From: Jacopo Mondi Reply-To: Jacopo Mondi Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When a request completes, a debug message is generated to help identify the request and the number of streams it contains. The printed number of streams is however the number of output buffers requested by the camera framework, not the number of streams generated by libcamera. In facts, some output buffers are generated by post-processing, and not directly from the camera. As the debug message prints the libcamera identifier for the Request, it is more logical to print the number of streams generated by the camera instead of the total number of streams. Reviewed-by: Hirokazu Honda Reviewed-by: Paul Elder Signed-off-by: Jacopo Mondi Signed-off-by: Paul Elder Reviewed-by: Umang Jain Reviewed-by: Laurent Pinchart --- src/android/camera_device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index 0be6114e3c2c..44e6a9fc6f9b 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -1184,7 +1184,7 @@ void CameraDevice::requestComplete(Request *request) notifyShutter(descriptor->frameNumber_, sensorTimestamp); LOG(HAL, Debug) << "Request " << request->cookie() << " completed with " - << descriptor->buffers_.size() << " streams"; + << descriptor->request_->buffers().size() << " streams"; /* * Generate the metadata associated with the captured buffers.