From patchwork Fri May 27 09:34:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 16070 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D38EEBD161 for ; Fri, 27 May 2022 09:35:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9B47265634; Fri, 27 May 2022 11:35:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1653644104; bh=0BZicPyxMBeyivBumWFrMPChHa1PrWSpE0d1yA43m5M=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=YMC+fhMMD5pM3nLLwqc4m7H/LME8mqbobTXWO5D6ddRKlHCvLdXwwG+Q6gfkn+DGM v8amjSmoK7QxygrEtQWf7hPv5zugL7REtskLqPWLaHOcO6UicYGATFZEEgDUqsP54/ u4+eBZDX2q4GnjkAIJhOHSJ/9QMZHnsUc7Hppv9+AOReY6GpRqIgVc0mxdE0nSkKCx CpH1MlSFuc/pRW41BuodCcOL7TihPkmfiRt8gPxg9ncVbMMa2ZtCiwV3ep+rVAnqQ+ FpufqxRWuP/pQzx+vi1CBirIYSzaaDivrY0a3tjEHNDJLn08au9hC3mXTqwF8+ySoC xbIcsxbDQMoeg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6385A65637 for ; Fri, 27 May 2022 11:35:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="FnlRa58H"; dkim-atps=neutral Received: from pyrite.rasen.tech (softbank036240126034.bbtec.net [36.240.126.34]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EE4532A; Fri, 27 May 2022 11:34:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1653644101; bh=0BZicPyxMBeyivBumWFrMPChHa1PrWSpE0d1yA43m5M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FnlRa58HoAUMzq44I6VbC5zp9OUfCowYFz6TYrYIsD/7cXD4ZKHXrTxdsCdTwaMpa YfHa84WPRLPgrGarQYOG/za/Vnr8koezPs2X7W1nweRk1MREy1KOSBXVVxgkH7nf1/ YluGGUMuoI7bjd5fY+R0eGB0D8gFHOYh2bF6B1pU= To: libcamera-devel@lists.libcamera.org Date: Fri, 27 May 2022 18:34:40 +0900 Message-Id: <20220527093440.953377-6-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220527093440.953377-1-paul.elder@ideasonboard.com> References: <20220527093440.953377-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 5/5] android: camera_device: Print the correct number of completed streams X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Paul Elder via libcamera-devel From: Paul Elder Reply-To: Paul Elder Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Jacopo Mondi When a request completes, a debug message is generated to help identify the request and the number of streams it contains. The printed number of streams is however the number of output buffers requested by the camera framework, not the number of streams generated by libcamera. In facts, some output buffers are generated by post-processing, and not directly from the camera. As the debug message prints the libcamera identifier for the Request, it is more logical to print the number of streams generated by the camera instead of the total number of streams. Reviewed-by: Hirokazu Honda Reviewed-by: Paul Elder Signed-off-by: Jacopo Mondi Signed-off-by: Paul Elder Reviewed-by: Umang Jain Reviewed-by: Laurent Pinchart --- Changes in v2: - fix typo in commit message --- src/android/camera_device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index 9ee34b93..dfff8ec4 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -1194,7 +1194,7 @@ void CameraDevice::requestComplete(Request *request) notifyShutter(descriptor->frameNumber_, sensorTimestamp); LOG(HAL, Debug) << "Request " << request->cookie() << " completed with " - << descriptor->buffers_.size() << " streams"; + << descriptor->request_->buffers().size() << " streams"; /* * Generate the metadata associated with the captured buffers.