From patchwork Wed May 25 22:24:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 16044 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6A2C8BD161 for ; Wed, 25 May 2022 22:25:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1F48E65671; Thu, 26 May 2022 00:25:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1653517516; bh=INnkauI5QY7zzg0eLFg/dvCTVOoF5Vo5N0zb8WkSeA4=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=1ayhZPuEUQIEi3hkINpDdVg9iZtYfmJloYrv8drPryQVGQyc9uvO6fZj5xKJNgRPp 53XlWezzX2O4WfvmvJ167VQM14YBsaawYXzsKhosgzxf+oVYVbi5yDVlx7pKCoyUew QQLvPK/4DL7EaB4uVthhzgqcRedO4qYbo9yH+kDDyK5SwxqMGxGZOx9v2e1Wc3mCBX M/rUU3ZOpqJBfTEdxIRdfvlNdYiLLftToF0zhEYlYFfTJ/qp+6Bn75xsrwBr2MFrD+ NKcU//45RYMixMivGDSlQpCKzUkLoPXJljmfS0Js4XKXo52Smz6eVcp8/8oJ2G3btV 7RiiCrUIi3AbA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 18D1060422 for ; Thu, 26 May 2022 00:25:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bdTA7vL+"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (ip-109-40-242-63.web.vodafone.de [109.40.242.63]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CDC2AFD; Thu, 26 May 2022 00:25:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1653517511; bh=INnkauI5QY7zzg0eLFg/dvCTVOoF5Vo5N0zb8WkSeA4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bdTA7vL+0NsOaQYeBJxX9fw7bO3axL3m1m8hwZ4hwHaqrpEx8usVX4dHoEfwGJY03 xdVymxGPdrLAaiEe5TUxYHUHY7t/WcwWqEMJkejNt4VT1tvmD3Y5kQVq80KkRj48U/ nP2FgaLdmwV6J2n8PyEO3z6NJxW/dqe4yoz5pp5A= To: libcamera-devel@lists.libcamera.org Date: Thu, 26 May 2022 01:24:59 +0300 Message-Id: <20220525222503.6460-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220525222503.6460-1-laurent.pinchart@ideasonboard.com> References: <20220525222503.6460-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/5] libcamera: base: log: Remove unnecessary local variable X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The output local variable in Logger::logSetTarget() isn't necessary. Remove it. Signed-off-by: Laurent Pinchart Reviewed-by: Umang Jain Reviewed-by: Paul Elder --- src/libcamera/base/log.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp index 64813b6607c5..df84ba4e8328 100644 --- a/src/libcamera/base/log.cpp +++ b/src/libcamera/base/log.cpp @@ -477,15 +477,11 @@ int Logger::logSetStream(std::ostream *stream) */ int Logger::logSetTarget(enum LoggingTarget target) { - std::shared_ptr output; - switch (target) { case LoggingTargetSyslog: - output = std::make_shared(); - std::atomic_store(&output_, output); + std::atomic_store(&output_, std::make_shared()); break; case LoggingTargetNone: - output = nullptr; std::atomic_store(&output_, std::shared_ptr()); break; default: