From patchwork Thu May 19 10:33:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 15986 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 24C09C326D for ; Thu, 19 May 2022 10:34:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 19DFB6566B; Thu, 19 May 2022 12:34:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1652956452; bh=S/RVNlIlL/i+4loRKEAVUW+1XNEtUENfvOvlbekWDYg=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Gsp2mVygVGiKtnI3FneVrQMRYGkR15WIj9GekcK/z0yaqMnoEPN9F2sXwK5X4NIws zyBqPrhfa2EV0tX4P/YJ9CkUEn3Rn30Di6sLiq9ZGTfPeI6sYI7z+CEbvbaqsrt9C+ qEkwHIjw86pJbl3DlN0Dw0H+8huw4KD4ABgVnpf0n/dT9fqUeAhdUwK904eC0peVqg IhFm2NDZtj4uf8QGWu9KPcLIlsG6gZbzT69Ubw/xjckP3/lngF3DM1vOEdOgftCTs2 6X0aa7N/m5ydjUh6pz+pv/lOxTkT4mJ7ff9yQO8sf62vZ9KfFTS+SwS19lDBxmf921 Z0hv+3yB4XZLA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7612D60420 for ; Thu, 19 May 2022 12:34:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="P4x+HBgr"; dkim-atps=neutral Received: from deskari.lan (91-156-85-209.elisa-laajakaista.fi [91.156.85.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E975410CC; Thu, 19 May 2022 12:34:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1652956448; bh=S/RVNlIlL/i+4loRKEAVUW+1XNEtUENfvOvlbekWDYg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P4x+HBgrXdSLHQgcv1nHegEnmJRFksVeIYjrFYdzFtJI/g2LaxpBOXVbT2GCx5C+O aSrRj3F3/DOXVNQvvTqhqLK124+RrRGYj+qZhnkjHz+BX2+pYpfoL/NiDzK+G13YeT 2AGTUBY3Qlrr+CxZyFEbV6G2Fed72HuIBRfyeMrg= To: libcamera-devel@lists.libcamera.org, David Plowman , Kieran Bingham , Laurent Pinchart , Jacopo Mondi Date: Thu, 19 May 2022 13:33:46 +0300 Message-Id: <20220519103347.33295-5-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220519103347.33295-1-tomi.valkeinen@ideasonboard.com> References: <20220519103347.33295-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 4/5] py: Fix SceneFlicker enum values X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tomi Valkeinen via libcamera-devel From: Tomi Valkeinen Reply-To: Tomi Valkeinen Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Stripping 'SceneFlicker' prefix from the enum value names leads to '50Hz' and '60Hz', which are not valid names. So add another heuristics to keep the prefix for SceneFlicker. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- src/py/libcamera/gen-py-control-enums.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/py/libcamera/gen-py-control-enums.py b/src/py/libcamera/gen-py-control-enums.py index dcc28b1a..6b2b5362 100755 --- a/src/py/libcamera/gen-py-control-enums.py +++ b/src/py/libcamera/gen-py-control-enums.py @@ -42,6 +42,9 @@ def generate_py(controls): if name == 'LensShadingMapMode': prefix = 'LensShadingMapMode' + elif name == 'SceneFlicker': + # If we strip the prefix, we would get '50Hz', which is illegal name + prefix = '' else: prefix = find_common_prefix([e['name'] for e in enum])