From patchwork Wed May 18 13:13:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 15960 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B4103C3271 for ; Wed, 18 May 2022 13:14:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 260C365675; Wed, 18 May 2022 15:14:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1652879645; bh=kk3f22MHUK4RaU0Hou0Ocit2U5vTR7pWRoYQV7nTU8k=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=imh+drDrcDFgMktBwhbYeNQEOJ7j72eDtS2cdu/1OwEvqNOhNYJHPdAgsQ0cl4nsT WwHOqprt1bFXZ63b5xLeiMmcFO1ISSzMW/Rm35UwElU7XxJGqP2QJNFLr/cR2uS1Nr K+1LCWL2+h3XAqPJi4r6U1bT6+WHNHfMW7j7asNsxFP76etOWV7+rwXJFaD44tPN8Q 1dPp88gP/GQuwk5y1DWG+mhPD0Rm4F8HackQzM7huZ9qoxSUOIpaxZcEy5gSZheFwQ zmQvzKPqPKq88i9R1O6enC/beJ33tabeJWjyH5D0Soqq5aD9Vsz2/fSlD4Vuf6Inun /Lxx0sIpqF+KQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 84B0C6566A for ; Wed, 18 May 2022 15:13:51 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="EPKtiGT3"; dkim-atps=neutral Received: from deskari.lan (91-156-85-209.elisa-laajakaista.fi [91.156.85.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EB0F1E50; Wed, 18 May 2022 15:13:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1652879631; bh=kk3f22MHUK4RaU0Hou0Ocit2U5vTR7pWRoYQV7nTU8k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EPKtiGT3kzKKnfcrFXygcQSJzrRJH8U8GRTKKTgkfDXYwm5HCvcz4zp4Idh9e9G8n GS9haDS/5+EBPZdkZjNJXqToVIwiJ4JWGIDx1OY0ONLTspjcZRBZlcbLYvgvou/0Ko cQ0vywKmrI873vavz7lEjpmrIVADnXu/zzNQnhfY= To: libcamera-devel@lists.libcamera.org, David Plowman , Kieran Bingham , Laurent Pinchart , Jacopo Mondi Date: Wed, 18 May 2022 16:13:21 +0300 Message-Id: <20220518131329.66994-11-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220518131329.66994-1-tomi.valkeinen@ideasonboard.com> References: <20220518131329.66994-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 10/18] py: cam_kms: fix multistream display X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tomi Valkeinen via libcamera-devel From: Tomi Valkeinen Reply-To: Tomi Valkeinen Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Instead of doing an atomic commit for each stream, do a single commit for the two planes. This fixes the issue that only the first plane was actually shown. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/py/cam/cam_kms.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py index f1844717..d8ff0284 100644 --- a/src/py/cam/cam_kms.py +++ b/src/py/cam/cam_kms.py @@ -75,12 +75,13 @@ class KMSRenderer: buffers = drmreq['camreq'].buffers + req = pykms.AtomicReq(self.card) + for stream, fb in buffers.items(): drmfb = self.cam_2_drm.get(fb, None) - - req = pykms.AtomicReq(self.card) self.add_plane(req, stream, drmfb) - req.commit() + + req.commit() def handle_page_flip(self, frame, time): old = self.current