From patchwork Wed Jul 3 13:58:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 1596 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A428A60C23 for ; Wed, 3 Jul 2019 15:58:35 +0200 (CEST) Received: from neptunite.flets-east.jp (p1871204-ipngn14001hodogaya.kanagawa.ocn.ne.jp [153.220.127.204]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AA30C24B; Wed, 3 Jul 2019 15:58:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1562162315; bh=vWaJvWcuirzfs4QRRFRw4+ZJz2TV5jj95bgtgqki0rI=; h=From:To:Cc:Subject:Date:From; b=EFBPMqdybbi5UUosLDh9y02KOx3gExnaFJnvMltCz9Y+3uM1w0AfVqzcrI8gSC454 hul41JqQ09+JaHqBnn+hQRiIvkmJV1w5z6mZZ1krfP6SAGpHzkozYduq5cUIicpuWf RGGxr/zaZnwxNw/9WRIFrUavulFBef2908+brC+4= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Wed, 3 Jul 2019 22:58:25 +0900 Message-Id: <20190703135825.32353-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3] libcamera: ipa_module: add path to module loading error message X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jul 2019 13:58:35 -0000 Add an error message to tell, if an IPA module failed to load, the path to the IPA module shared object that was attempted to be loaded. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- Changes in v3: - error message wording change - moved to under the close: label Changes in v2: don't show module version src/libcamera/ipa_module.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp index 58e8d1d..477f4b8 100644 --- a/src/libcamera/ipa_module.cpp +++ b/src/libcamera/ipa_module.cpp @@ -289,6 +289,11 @@ int IPAModule::loadIPAModuleInfo() unmap: munmap(map, soSize); close: + if (ret) + LOG(IPAModule, Error) + << "Error loading IPA module " + << libPath_; + close(fd); return ret; }