From patchwork Tue May 10 11:51:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 15861 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 220D0C326D for ; Tue, 10 May 2022 11:52:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C6A5D65662; Tue, 10 May 2022 13:52:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1652183544; bh=R6JzINy4gD6TovfrdcP/5VdD1wSGdqHELXNnBkONj8c=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZZLyRJ9KK45A+VjYMwz4KHW/RX08wJdzCeeL29H90sfIr6ZgMirMaF4wu3vrGIr6r +mXcd8xngbK6OfP1vyY155WtiVIp/cX9TVR7nyXCWBfHPdo1MICDDI3UGrtIrVCxiO rxXJ4LRD8SQGzIuwDcXVEwyVySsI8G4mlxbz5x4SBEiRlAhj0zOb5ImI2qYPNJyAj7 lj4DQEY1qnMK5DeTZpDkdiAVjJwrCgbbu+4DJQFDg+y3/wRLkBxs4lnAc3WAm/chFn iiyv9fLqxOdeWRAUuE2o9YVr6zSPVqO7K+P8adlbGggFidtfSuMlS5tcIWqhqUCF5k IMc5rX8ta63bQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 160D565657 for ; Tue, 10 May 2022 13:52:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="jGakV36x"; dkim-atps=neutral Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B984B9A; Tue, 10 May 2022 13:52:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1652183534; bh=R6JzINy4gD6TovfrdcP/5VdD1wSGdqHELXNnBkONj8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jGakV36xfs98cH7SaRJFTMQxLMeDKH1ao8k9mZ0ozBZlTYYnm3DKxtKhpnKdLIEeh Uz84ZYrzL/pr4QZFhI/FSz/nAdofxekGFuhH6pNR53d2Vfy1/1SJ4rG75Z2waJ96LT US5MVsKUpzEBY3d2pZ3i9vcHwR74JBkxTc4NAqE8= To: libcamera-devel@lists.libcamera.org Date: Tue, 10 May 2022 14:51:18 +0300 Message-Id: <20220510115147.19360-22-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510115147.19360-1-laurent.pinchart@ideasonboard.com> References: <20220510115147.19360-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 21/50] staging: media: imx: imx7-media-csi: Don't initialize unused fields X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Cc: Martin Kepplinger , kernel@pengutronix.de, Dorota Czaplejewicz , Alexander Stein , Rui Miguel Silva , Philipp Zabel , Steve Longerbeam Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The imx_media_dev structure contains three fields that are not used by this driver or any helper code that it calls. Don't initialize them. Signed-off-by: Laurent Pinchart --- drivers/staging/media/imx/imx7-media-csi.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c index b6643952da25..7e932884fd02 100644 --- a/drivers/staging/media/imx/imx7-media-csi.c +++ b/drivers/staging/media/imx/imx7-media-csi.c @@ -1821,8 +1821,6 @@ static int imx7_csi_media_dev_init(struct imx7_csi *csi) imxmd->md.ops = &imx7_csi_media_ops; imxmd->md.dev = csi->dev; - mutex_init(&imxmd->mutex); - imxmd->v4l2_dev.mdev = &imxmd->md; strscpy(imxmd->v4l2_dev.name, "imx-media", sizeof(imxmd->v4l2_dev.name)); @@ -1838,10 +1836,6 @@ static int imx7_csi_media_dev_init(struct imx7_csi *csi) goto cleanup; } - INIT_LIST_HEAD(&imxmd->vdev_list); - - v4l2_async_nf_init(&imxmd->notifier); - return 0; cleanup: