From patchwork Tue May 10 11:51:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 15850 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0EBC3C3256 for ; Tue, 10 May 2022 11:52:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B3B126566F; Tue, 10 May 2022 13:52:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1652183532; bh=d+7BkkERKznRknT/kY5nL7k0K2j0jSnisRVTDGKQ6Co=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YocrLsXwQjqt50Sa87b24uY0FfwjZiZOsS7SGa/bSOjgIiidG6d8MsqdFk+2YERFG BRzvG4uVy6SPVLO008IUgkTvr5hxmFlq6oEQ0XQm/0QXeSssG1X2fwJMgZVYmcXmOO I/9nZ4BI+P5CJYCw7mfRtRFlNpSRTtM/D7SwAWmIrh2JgTXcXiVpiuW3i5/wLJovrc vM6Pq3h11nKIURV96j5l6QHE5ZFiW++27D7BWJ8M8QATs485QeyqLkQxS/Chkrch75 TrnmmfJziDBui/zvkvbnwSgo6dZTVWeVCqQVOoGXvpMy5MC0n/qBPKTQFjoA7h6r+7 oGALGjTDhMvkw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F02A65646 for ; Tue, 10 May 2022 13:52:05 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="eJUQtjfG"; dkim-atps=neutral Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 89EF1DFF; Tue, 10 May 2022 13:52:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1652183525; bh=d+7BkkERKznRknT/kY5nL7k0K2j0jSnisRVTDGKQ6Co=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eJUQtjfGxAKAf2OIwldmbr5OUD0Rqij0Wo52xqyQ4t96QKzGN6bcfomk+XuuLt0aH lvNvyIPhMIJY252kTUdfnxRJfvgK72jnMBO8e7GZMXZlMCk1Z99pSHPWqSsho2KvNT tfbgRqSp+08i3Ae06KAE8vxcqH6UCAW43iJKw/nM= To: libcamera-devel@lists.libcamera.org Date: Tue, 10 May 2022 14:51:07 +0300 Message-Id: <20220510115147.19360-11-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510115147.19360-1-laurent.pinchart@ideasonboard.com> References: <20220510115147.19360-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 10/50] staging: media: imx: imx7-media-csi: Remove imx_media_of_add_csi X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Cc: Martin Kepplinger , kernel@pengutronix.de, Dorota Czaplejewicz , Alexander Stein , Rui Miguel Silva , Philipp Zabel , Steve Longerbeam Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Paul Elder imx_media_of_add_csi() from imx-media-of.c validates that the fwnode for the CSI bridge is enabled, and adds the fwnode to the async notifier of the imxmd. The former is redundant, as if the CSI bridge driver probes, clearly it is enabled in the DT. The latter is not needed as the imxmd notifier isn't used anymore. The call is thus not needed and can be dropped. This removes the dependency of imx7-media-csi.c on imx-media-of.c. Signed-off-by: Paul Elder --- drivers/staging/media/imx/imx7-media-csi.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c index d85b5ab204df..e7dcb602afae 100644 --- a/drivers/staging/media/imx/imx7-media-csi.c +++ b/drivers/staging/media/imx/imx7-media-csi.c @@ -1203,12 +1203,6 @@ static int imx7_csi_media_init(struct imx7_csi *csi) if (IS_ERR(imxmd)) return PTR_ERR(imxmd); - ret = imx_media_of_add_csi(imxmd, csi->dev->of_node); - if (ret < 0 && ret != -ENODEV && ret != -EEXIST) { - imx7_csi_media_cleanup(csi); - return ret; - } - csi->imxmd = imxmd; v4l2_subdev_init(&csi->sd, &imx7_csi_subdev_ops);