From patchwork Tue Apr 26 09:14:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harvey Yang X-Patchwork-Id: 15719 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 36F2DC0F1B for ; Tue, 26 Apr 2022 09:16:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D678E65642; Tue, 26 Apr 2022 11:16:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1650964562; bh=MY8s5OVh76SUxRhlo1CHxzmj/Ds7Vml2S55M3asVEYw=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WuacUDMO5ljH7Vj4LvxxtuwFGhfaxd0xO3zqSb39zIBYSrs/HYG/Woxovbvb3Ey8Y zNs6NRUadP50p2U0jP71mBA/G/l1HXUfzOZCGIAu5FG79Ern6iN8Pm80WMEFzJLwgd EWto2IlK9c0UTntbu59qgKJD/UEp3LXxjmehyGmy5O5iv4ob/Axijr6Z4wy8J+HW5N dl8DGM66b4R+FtEyD8GF++SYY4qk68Xqpg7vlNTVWW1VgmWJr/neMrOGavMlHi4sQx n6PS8/2iFTFnHFJEDryC1CYOMgTweN3uXCK1JI9wUuKWSXr68p5Q7dz0TEYwD3+xIn wM/rkzbLh3Sew== Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FC4260431 for ; Tue, 26 Apr 2022 11:16:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="K2cAX/Oe"; dkim-atps=neutral Received: by mail-pj1-x1036.google.com with SMTP id s14-20020a17090a880e00b001caaf6d3dd1so1694107pjn.3 for ; Tue, 26 Apr 2022 02:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=coaS5RWqTLoXtJP51hv+aKejO7ClDzrYPRhHfrlXIJ0=; b=K2cAX/OeJG9GXPYCUIU5WCJXBUvqtsavpE0YdI1EZPqyhRN8Aye2vdZKgq8qp/Swk4 7zpelQ0ZKNSFjEM4KDvEf3cauQs+JEQ+o6OWRDOaO0aiJcc6A8iI7enbPYgKJUyRk+gd lmgRHGSoifVWAED2xgXGTKPW9xHVwQhb1NsWQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=coaS5RWqTLoXtJP51hv+aKejO7ClDzrYPRhHfrlXIJ0=; b=zJhhoqrTMHjiyLn8ddv6DMMMNkmmkr2gcF9NoFC2GV+SFhrycHHPu5DWB/zKiCjtn+ IJKnksJzrd038722J1mrD+FKjb6dgxIxv0JPR0ZB2/Ul0t/jMs3t5rbHUvpUPcXjX3rg wx4HJYPQaA2K/qGugcksPeCV3KTfiT1ynkPaZR3M8Rjlxm7N9v5KQDsIih2GzZN+3QfE 16VEOK2G5yRoqC7qIpEZL/5naA8+6h2v9savc2aRLSNqLDXKu3AUa0+jW2HDQLJsZi2z HjewypI7W0wZKkSTHPLdR0XEIAg0DSKpSPuLPCP8UK4LASsySckD1uWAyt853NsivBs5 2exA== X-Gm-Message-State: AOAM530Bs7o8RgNshqOpUlRIxbahka9fycsx+AEnyUDC8AuOok9SfNpM rS6+yDzk7qvKVG26UDn9ip8rwj4i9XCtQj0B X-Google-Smtp-Source: ABdhPJygdfQVtGIVyImZc1uaGKFye/FSsUKhDaHn6ytSYf16ETxlwEb7IHmdgBEiOt4pysQzy4CIrw== X-Received: by 2002:a17:902:7e83:b0:158:ae65:b926 with SMTP id z3-20020a1709027e8300b00158ae65b926mr13570076pla.41.1650964559164; Tue, 26 Apr 2022 02:15:59 -0700 (PDT) Received: from chenghaoyang.c.googlers.com.com (93.135.240.35.bc.googleusercontent.com. [35.240.135.93]) by smtp.gmail.com with ESMTPSA id w123-20020a623081000000b005056a4d71e3sm14441042pfw.77.2022.04.26.02.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 02:15:58 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Tue, 26 Apr 2022 09:14:06 +0000 Message-Id: <20220426091409.1352047-2-chenghaoyang@chromium.org> X-Mailer: git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog In-Reply-To: <20220426091409.1352047-1-chenghaoyang@chromium.org> References: <20220426091409.1352047-1-chenghaoyang@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 1/4] Allow inheritance of FrameBuffer X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harvey Yang via libcamera-devel From: Harvey Yang Reply-To: Harvey Yang Cc: Harvey Yang Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" To add buffer_handle_t access in android, this CL allows inheritance of FrameBuffer to add a derived class in android. Signed-off-by: Harvey Yang --- include/libcamera/framebuffer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h index 3b1118d1..e6c769b4 100644 --- a/include/libcamera/framebuffer.h +++ b/include/libcamera/framebuffer.h @@ -46,7 +46,7 @@ private: std::vector planes_; }; -class FrameBuffer final : public Extensible +class FrameBuffer : public Extensible { LIBCAMERA_DECLARE_PRIVATE() @@ -61,6 +61,7 @@ public: FrameBuffer(const std::vector &planes, unsigned int cookie = 0); FrameBuffer(std::unique_ptr d, const std::vector &planes, unsigned int cookie = 0); + virtual ~FrameBuffer() {} const std::vector &planes() const { return planes_; } Request *request() const;