From patchwork Fri Apr 8 10:54:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 15659 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CB4F0C3260 for ; Fri, 8 Apr 2022 10:54:51 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7ADF565641; Fri, 8 Apr 2022 12:54:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1649415291; bh=16RTJpVFXa8IWys/5ynUQcpwASj3qYWNZxSeYsJhrhI=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=sn1uvLY5zb5IwiFsy5NJkD2ZTOLsKFUuW2vajKs1EoPrvKgXCxNaRefEX1D+g6vra QJbRfu/313R0lGPb0bGBxMI+Bvy0DFyKI1/MbKo0lIWIDu0OnTUDh2f7s5WFzmUOU+ n+FCvw1cm2XQxf1G3sj5ZOKt6liOPqJHBKu/uuzhnbrKRS5wGGsBAdQ+Mc77LCov7n kTdGaOK/S+bgwkiwnpa6qL4WHmVuUXGahbtdazY7hLb8jSh9LE87ZjpNscbSpeNOeF YYYsAf2EdEErV625r8MfwtC93GuQU9nbdQYsNuAjhiV5/u6zHsMtupwFbg4ijSUL/M fZX8fMIHMwfSw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C1C8065640 for ; Fri, 8 Apr 2022 12:54:49 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VcYxtLSz"; dkim-atps=neutral Received: from perceval.ideasonboard.com (unknown [27.57.186.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BCF39499; Fri, 8 Apr 2022 12:54:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1649415289; bh=16RTJpVFXa8IWys/5ynUQcpwASj3qYWNZxSeYsJhrhI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VcYxtLSz94GrMzbGDg80L/lajvKYMdCgynV6ftr1K7PIEZHgL6J+MVbjJFCk3hC8x H+xT/LzC+xhIGvc+ElO4mnHRLeGwc92LD/Sz0+6jTRA9zLHtyers2Vrcj77ndVHZSk L0tdXRAIss6NOmSEdagiSTtblaCayWbQ1kvOpZmI= To: libcamera-devel@lists.libcamera.org Date: Fri, 8 Apr 2022 16:24:38 +0530 Message-Id: <20220408105439.144182-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220408105439.144182-1-umang.jain@ideasonboard.com> References: <20220408105439.144182-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] ipa: vimc: Establish logical order of operations X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" It is preferred that the interface definition should represent the logical order in which the operations will be called. The patch has no functional changes. Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham --- include/libcamera/ipa/vimc.mojom | 2 +- src/ipa/vimc/vimc.cpp | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom index e5ac3609..cdc03ffb 100644 --- a/include/libcamera/ipa/vimc.mojom +++ b/include/libcamera/ipa/vimc.mojom @@ -30,6 +30,7 @@ interface IPAVimcInterface { mapBuffers(array buffers); unmapBuffers(array ids); + [async] queueRequest(uint32 frame, libcamera.ControlList controls); /* * The vimc driver doesn't use parameters buffers. To maximize coverage * of unit tests that rely on the VIMC pipeline handler, we still define @@ -37,7 +38,6 @@ interface IPAVimcInterface { * handle parameters at runtime. */ [async] fillParams(uint32 frame, uint32 bufferId); - [async] queueRequest(uint32 frame, libcamera.ControlList controls); }; interface IPAVimcEventInterface { diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp index 315302c6..a62e72b0 100644 --- a/src/ipa/vimc/vimc.cpp +++ b/src/ipa/vimc/vimc.cpp @@ -43,8 +43,8 @@ public: void mapBuffers(const std::vector &buffers) override; void unmapBuffers(const std::vector &ids) override; - void fillParams(uint32_t frame, uint32_t bufferId) override; void queueRequest(uint32_t frame, const ControlList &controls) override; + void fillParams(uint32_t frame, uint32_t bufferId) override; private: void initTrace(); @@ -129,6 +129,11 @@ void IPAVimc::unmapBuffers(const std::vector &ids) } } +void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame, + [[maybe_unused]] const ControlList &controls) +{ +} + void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId) { auto it = buffers_.find(bufferId); @@ -140,11 +145,6 @@ void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId) paramsFilled.emit(bufferId); } -void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame, - [[maybe_unused]] const ControlList &controls) -{ -} - void IPAVimc::initTrace() { struct stat fifoStat;