From patchwork Tue Mar 29 11:29:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 15583 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 49FB7C0F1B for ; Tue, 29 Mar 2022 11:29:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E1BDF65635; Tue, 29 Mar 2022 13:29:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1648553377; bh=uJkdLyKKi1CM7U78WY3/9v8M7LaHmqKbeWqVheZf5rM=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=DnDMFZs3e/P/eeYf2NI6mLHH/BuyBue1dqqpWeMxRWoFJ/x3lptVD5hDdNu+Ea6lQ B/i34hGXG5HC3f2RY9QLpk2wjysYuP5WeFlbdeiQz9OrzAtjrf5Ch24ZZBOyFXsUmU Y+unX9i3GZOj4h1F4E3cMLRjSbuA5+gv9dG4UvmQ2HKIja8MG6UE0k1E0t3QSyhFxe pz/lT0yR4wArH+5F0ZZUCFbVbVVltk8jg8Yxph9bAWRPAdZBxSPhcrRnKDuO5S+D/+ FdsNF0xab3ZnkDeY9N2ROmpA3AuFFolhNsJ87QsW8yCmTqCeQ4jgYB+VCFC4meKcQ2 vM1N2fHgX+evg== Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 74B1B604C5 for ; Tue, 29 Mar 2022 13:29:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="lBBgkEzB"; dkim-atps=neutral Received: by mail-wr1-x433.google.com with SMTP id m30so24360637wrb.1 for ; Tue, 29 Mar 2022 04:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YymQGyzOkJ/fWIcmhh9T0m5zlCZROtuZjEIX+kkvOFQ=; b=lBBgkEzBnAqXTMiLdHQCLcO9U/cP3po6VfvxyIO0WrE+wZ2WJpuR3lT5OP9XO7hZlR y/mpAXdahEFVGFFiIjWo5cXlihUXhKjnG4ooekOhYyUYgwy7A3bnWF+U481vVBdQ/5M1 6fgsPGQZfMB/ylVJ6o+w5kBzu31I3b/G0g/JgaxOKAFpsVRKFOgUBVPtab8zqAsvikd7 r3UnE6iDpVAjHxqp6kZQ68ghEiJWCfLAT1sSboKWXc8u1G0bk43iAz3YPESBtSXKM1tH k/esSC7WQsLkP3dGRu/EbtlnabiUxjRMuWkdkEIDEvHQW8uzCJWYCaLoxwuQ8zurac7R LC/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YymQGyzOkJ/fWIcmhh9T0m5zlCZROtuZjEIX+kkvOFQ=; b=n8dVKZW6v7QQs2w8j69qvk2OwibvHI+rfuNTntoUrV2wRk7NEhPjpxArK2jsdcFwGW xPyZBgdhkFHIA/tI/eXQPLhp9vaiXuOfs0R2v9Hswa5FhWL7hygEAXYxQIOeGP7YUq/D jwPHLGipq/Vh2LRF/8QjdcYfruubEYJ4nG1wosdxxCvVph0LAOqa2jYfZ6rTbH2XJgvO 7S4j8/olXpDgOgg60fAk2osxhKJdSAlHN4dSXGmbY0huLstd5OTgo2wnE3CNgRkZmHX3 EGVWnFb0I6BUs1lt/80HAsKEIiS07Y9ZqetW+RepjOUuIGREWzYZitkQfNYj1UOUmth8 mxRw== X-Gm-Message-State: AOAM53104gQOjskTtZQtgoOrTkjOtgBMIX3f7W2MQ+tauRpc2xkA2eRe EhGgRMYwFxjWmDKPq0NRaOxyAPlFHG/Gow== X-Google-Smtp-Source: ABdhPJxnGfG5mtchbMFio84bRKIgVL/YZea2a7i9MmUg0Bmc81gkvVPhYyKOJuqhE4sZMbJ7SBhEUQ== X-Received: by 2002:adf:cc89:0:b0:203:f654:116a with SMTP id p9-20020adfcc89000000b00203f654116amr29848750wrj.320.1648553375986; Tue, 29 Mar 2022 04:29:35 -0700 (PDT) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:e34f:94fd:5684:9ead]) by smtp.gmail.com with ESMTPSA id bi20-20020a05600c3d9400b0038cfe80eeddsm1767436wmb.29.2022.03.29.04.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Mar 2022 04:29:35 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Tue, 29 Mar 2022 12:29:29 +0100 Message-Id: <20220329112929.465434-3-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220329112929.465434-1-naush@raspberrypi.com> References: <20220329112929.465434-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 3/3] test: v4l2_videodevice: Verify the Dequeue Watchdog X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Kieran Bingham Add a test that captures 5 frames, with a short (5ms) watchdog. The default framerate of the VIMC pipeline should ensure that we never meet this watchdog, and the timeout should activate. Signed-off-by: Kieran Bingham Signed-off-by: Naushir Patuck Reviewed-by: Laurent Pinchart --- test/v4l2_videodevice/dequeue_watchdog.cpp | 96 ++++++++++++++++++++++ test/v4l2_videodevice/meson.build | 1 + 2 files changed, 97 insertions(+) create mode 100644 test/v4l2_videodevice/dequeue_watchdog.cpp diff --git a/test/v4l2_videodevice/dequeue_watchdog.cpp b/test/v4l2_videodevice/dequeue_watchdog.cpp new file mode 100644 index 000000000000..0cb4de6f81a0 --- /dev/null +++ b/test/v4l2_videodevice/dequeue_watchdog.cpp @@ -0,0 +1,96 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (C) 2022, Ideas on Board Oy. + * + * libcamera V4L2 dequeue watchdog test + */ + +#include + +#include +#include +#include + +#include + +#include "v4l2_videodevice_test.h" + +using namespace libcamera; +using namespace std::chrono_literals; + +class DequeueWatchdogTest : public V4L2VideoDeviceTest +{ +public: + DequeueWatchdogTest() + : V4L2VideoDeviceTest("vimc", "Raw Capture 0"), frames_(0), barks_(0) {} + +protected: + int run() + { + constexpr unsigned int bufferCount = 8; + + EventDispatcher *dispatcher = Thread::current()->eventDispatcher(); + Timer timeout; + + int ret = capture_->allocateBuffers(bufferCount, &buffers_); + if (ret < 0) + return TestFail; + + capture_->dequeueTimeout.connect(this, &DequeueWatchdogTest::barkCounter); + capture_->setDequeueTimeout(5ms); + + capture_->bufferReady.connect(this, &DequeueWatchdogTest::receiveBuffer); + + for (const std::unique_ptr &buffer : buffers_) { + if (capture_->queueBuffer(buffer.get())) { + std::cout << "Failed to queue buffer" << std::endl; + return TestFail; + } + } + + capture_->streamOn(); + + timeout.start(5s); + while (timeout.isRunning()) { + dispatcher->processEvents(); + if (frames_ > 5) + break; + } + + std::cout << "Processed " << frames_ << " frames_ and heard " + << barks_ << " barks_" << std::endl; + + if (!barks_) { + std::cout << "Failed to hear any barks_." << std::endl; + return TestFail; + } + + capture_->streamOff(); + + return TestPass; + } + +private: + void receiveBuffer(FrameBuffer *buffer) + { + if (buffer->metadata().status == FrameMetadata::FrameCancelled) + return; + + std::cout << "Buffer received" << std::endl; + frames_++; + + /* Requeue the buffer for further use. */ + capture_->queueBuffer(buffer); + } + + void barkCounter() + { + std::cout << "Watchdog is barking" << std::endl; + barks_++; + } + + unsigned int frames_; + unsigned int barks_; +}; + +TEST_REGISTER(DequeueWatchdogTest) diff --git a/test/v4l2_videodevice/meson.build b/test/v4l2_videodevice/meson.build index 643f82edce5e..7a26f53d106a 100644 --- a/test/v4l2_videodevice/meson.build +++ b/test/v4l2_videodevice/meson.build @@ -6,6 +6,7 @@ v4l2_videodevice_tests = [ ['double_open', 'double_open.cpp'], ['controls', 'controls.cpp'], ['formats', 'formats.cpp'], + ['dequeue_watchdog', 'dequeue_watchdog.cpp'], ['request_buffers', 'request_buffers.cpp'], ['buffer_cache', 'buffer_cache.cpp'], ['stream_on_off', 'stream_on_off.cpp'],