From patchwork Fri Mar 25 09:25:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 15555 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 80495C3264 for ; Fri, 25 Mar 2022 09:26:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 34B18604DA; Fri, 25 Mar 2022 10:26:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1648200367; bh=M1ZcY7OhxCoMapUJ81i5L9ddTveG40LiKFBBuN8qkIc=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=T60q8uQqkwNABSi9x4xhvFB30UYFDSvZ++rC65Z7lBumqdHFwEDUAKrnZoPW8gAr7 CJeuR2Mzv8KYYbT2o8J+IehMZbd7FfTZ0dv/VPTVbOwmTWLY/CXiJzZDn76dwIRnfQ cU723Uv4hG7dEjj7BImA0hlEsi9WhAd9gw67uJ03ynTEjR84P2XSd/uQ1X/SEbngGZ afyFFVS8iPn+fJwqfuas3IGotsB5eOOwCNWMUdWexFgnF2pGhQbBIVIdE5JbmnGgaV ro76SO/3bhW4Gf38EYXcWUj/eqDOPkBRynwKnV0GgDxmGBq2f9pI0Y5a5CigDk4UPP V5Hr3WIh7hbdA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D8C62604E8 for ; Fri, 25 Mar 2022 10:26:01 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="PAakxMqA"; dkim-atps=neutral Received: from Monstersaurus.ksquared.org.uk.beta.tailscale.net (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 75D66E1F; Fri, 25 Mar 2022 10:26:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1648200361; bh=M1ZcY7OhxCoMapUJ81i5L9ddTveG40LiKFBBuN8qkIc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PAakxMqA25BoHU/gLk+4sPyFf4rI8UAKNiBF7TsCpIfk1YSZnyf+7dM4yWl5Fwdmq WxoQVH4xLLDqnmKE0lE28QedZrFwpO5d8Os65u5uxpbg5Ut4EzmPP9SlcpCssoqXV1 bR5ENA4cwMOjg6djaJ/c7qOm22VIV5OJqaOuj98A= To: libcamera devel , Kate Hsuan , Jean-Michel Hautbois Date: Fri, 25 Mar 2022 09:25:55 +0000 Message-Id: <20220325092555.1799897-6-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220325092555.1799897-1-kieran.bingham@ideasonboard.com> References: <20220325092555.1799897-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 5/5] ipa: ipu3: af: Simplify accumulations of y_items X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kieran Bingham via libcamera-devel From: Kieran Bingham Reply-To: Kieran Bingham Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Simplify the accumulation of the total and variance with a ternary operator. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart Reviewed-by: Jean-Michel Hautbois --- src/ipa/ipu3/algorithms/af.cpp | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp index c0f2d34368cb..6c25d02ec7f0 100644 --- a/src/ipa/ipu3/algorithms/af.cpp +++ b/src/ipa/ipu3/algorithms/af.cpp @@ -341,20 +341,14 @@ double Af::afEstimateVariance(Span y_items, bool isY1) double mean; double var_sum = 0; - for (auto y : y_items) { - if (isY1) - total += y.y1_avg; - else - total += y.y2_avg; - } + for (auto y : y_items) + total += isY1 ? y.y1_avg : y.y2_avg; mean = total / y_items.size(); for (auto y : y_items) { - if (isY1) - var_sum += pow(y.y1_avg - mean, 2); - else - var_sum += pow(y.y2_avg - mean, 2); + double avg = isY1 ? y.y1_avg : y.y2_avg; + var_sum += pow(avg - mean, 2); } return var_sum / y_items.size();