From patchwork Wed Mar 23 13:56:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 15523 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8B1EEC3264 for ; Wed, 23 Mar 2022 13:56:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 12285604E9; Wed, 23 Mar 2022 14:56:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1648043787; bh=ksqITB42MM48DgLEZ5ynX4or9LnP0P5pmn4QxUXRY/g=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=R61D1QuPed4r5b5u6ZXthGaGjqqPtedt/QvzwqkDqlDvQXIiZV5ASGBt3bf15oiTG W7Xcsyj3+HjGd8xGf9Rhirs7LwckGXsA0sYlCRSnlFrfdSBnB1LGhaRuYlz9c9pq+Y zQii1BKgj2z4+MBSmVM3ImtwPiwYiAiZzqARuYH4D8DbTX+jJ7w8o5WgwrftjJPr2d ttPM5+I2O5INmZHaCsY0oqjzoy0fA62MN2U+vermL2gKGGgZSGoJuTrlkWD4KhVnYy jTa0bCtgLaNFdi3ImNJa6pdX0vbxin0hLsdxd93uNxNL67CyQ80/R/mdLfvLfrVepU Fjw5oVIyUdwzQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A92A8604E8 for ; Wed, 23 Mar 2022 14:56:21 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ntzbQ2zv"; dkim-atps=neutral Received: from Monstersaurus.ksquared.org.uk.beta.tailscale.net (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 57A349DE; Wed, 23 Mar 2022 14:56:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1648043781; bh=ksqITB42MM48DgLEZ5ynX4or9LnP0P5pmn4QxUXRY/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ntzbQ2zvHPpuePQjXPcw6LpfW93rQ90IhRH8s2F2rgknbBwA64ue27E2wEIYU6jsU U7PM+rXc1xrf7yzqjacKtjGlEXnSrqnM44LeB7IX2yT5C8rs2jDTdXiiUCVoPMNob7 7aTC/1H28HT+cBX3E2P8LTO83RTkTF6XcIAr/Sgg= To: libcamera devel Date: Wed, 23 Mar 2022 13:56:14 +0000 Message-Id: <20220323135614.865252-6-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220323135614.865252-1-kieran.bingham@ideasonboard.com> References: <20220323135614.865252-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 5/5] ipa: ipu3: af: Simplify accumulations of y_items X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kieran Bingham via libcamera-devel From: Kieran Bingham Reply-To: Kieran Bingham Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Simplify the accumulation of the total and variance with a ternary operator. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- This is optional really, it's only really a stylistic preference. src/ipa/ipu3/algorithms/af.cpp | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp index ff5e9fb5b3c5..940ed68ea14a 100644 --- a/src/ipa/ipu3/algorithms/af.cpp +++ b/src/ipa/ipu3/algorithms/af.cpp @@ -342,20 +342,14 @@ double Af::afEstimateVariance(Span y_items, bool isY1) double mean; double var_sum = 0; - for (auto y : y_items) { - if (isY1) - total += y.y1_avg; - else - total += y.y2_avg; - } + for (auto y : y_items) + total += isY1 ? y.y1_avg : y.y2_avg; mean = total / y_items.size(); for (auto y : y_items) { - if (isY1) - var_sum += pow((y.y1_avg - mean), 2); - else - var_sum += pow((y.y2_avg - mean), 2); + double avg = isY1 ? y.y1_avg : y.y2_avg; + var_sum += pow((avg - mean), 2); } return var_sum / static_cast(y_items.size());