From patchwork Tue Mar 22 01:31:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kate Hsuan X-Patchwork-Id: 15491 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D3B11BD80A for ; Tue, 22 Mar 2022 01:31:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1FE48604D4; Tue, 22 Mar 2022 02:31:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1647912713; bh=OJxOuLUOhT74OYGzK4z/FMv37tT59d5QyhblTVzzp40=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=KR2fTge0oTp+W+WzgDemjZKGegNoKV7if2w9yOpTQpL5tV7KINGZ0bC9BrH0Ayh3+ 2ietSYD/trSOL4t2xVulXrRgxuHuvwqL1xrGymjsSRPb8JFVLOnF65/vUyoZkUuw6Y zBm0PeO8k/NSSIrsBPbmZ64G3Xtu3vtL+7PXL9Yat5tn8XNZNlD0x7lDQIn8aPTro9 JnLhVz1YJQH4yblCJNZa9tpsd4GXPMHb9ZMAujvwx7IXMABkRyi2XiCGdxG1ocKVsU 4EUfco7Pv/hVyGRBAe/RycCwJZm6Ila4a1zKUsaP96hFUoGD2fL7oCpZj3BDJrq3l8 oOwjsHdxMxW4Q== Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 65DD0604C7 for ; Tue, 22 Mar 2022 02:31:50 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="HK3DqHkd"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647912709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1U+LoOBKaucRHi2ou9lvYbhz6H9fW6wAMoq3TggJDJs=; b=HK3DqHkdT+oLYKRxf22sL46D8b1dFtdD0GtPeW0KaGQWMOIJ/mn3mFGuv4wBe0U6NYxFBr 1TlGOkFLQ1nKX2YItI1TnGNotunaUT5JLDCdwIUTa4Y4SlJ4iS8b9aLIleKGVO3DA0jbcd 825Y51CQpLRBETpawvqkbohWCouOenw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-155-wZdZK3uCNRC2ksr7jvGnLw-1; Mon, 21 Mar 2022 21:31:46 -0400 X-MC-Unique: wZdZK3uCNRC2ksr7jvGnLw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AC94E83395E for ; Tue, 22 Mar 2022 01:31:45 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.39.192.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CABB40CF8FB; Tue, 22 Mar 2022 01:31:43 +0000 (UTC) To: libcamera devel Date: Tue, 22 Mar 2022 09:31:19 +0800 Message-Id: <20220322013119.4262-1-hpa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hpa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [libcamera-devel] [PATCH] ipa: ipu3: af: Set default grid block width to the minimum value X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kate Hsuan via libcamera-devel From: Kate Hsuan Reply-To: Kate Hsuan Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Since x coordinate is incorrectly computed by a kernel issue, the block width should be set to 4 to prevent using the second stripe when setting the AF scene to the centre of the image. A kernel patch had fixed this issue. Therefore, this value can be set to the default minimum value. Signed-off-by: Kate Hsuan --- The kernel patch is shown as following URL. https://lore.kernel.org/linux-media/CAEth8oES8abPO4p7eFv43PwDXuxeOmg1661YtVvykBPrkagzKg@mail.gmail.com/T/#mb02fa73ce9e3089a4619c318badb2047a3ac39e2 --- src/ipa/ipu3/algorithms/af.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h index 13c7e0e8..108fcd18 100644 --- a/src/ipa/ipu3/algorithms/af.h +++ b/src/ipa/ipu3/algorithms/af.h @@ -20,7 +20,7 @@ static constexpr uint8_t kAfMinGridWidth = 16; static constexpr uint8_t kAfMinGridHeight = 16; static constexpr uint8_t kAfMaxGridWidth = 32; static constexpr uint8_t kAfMaxGridHeight = 24; -static constexpr uint16_t kAfMinGridBlockWidth = 4; +static constexpr uint16_t kAfMinGridBlockWidth = 3; static constexpr uint16_t kAfMinGridBlockHeight = 3; static constexpr uint16_t kAfMaxGridBlockWidth = 6; static constexpr uint16_t kAfMaxGridBlockHeight = 6;