From patchwork Wed Mar 16 09:39:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 15458 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4324CC3262 for ; Wed, 16 Mar 2022 09:39:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DD9B8632E2; Wed, 16 Mar 2022 10:39:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1647423597; bh=39nx0jN/BSL7NAeiCDh5ROPoY0goom8ufH1EyAcYehc=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=zzhQSASIi6J031zRZjd5uwcNfUa/0DBexHQVlvCiwWplqOQ6z2PbF+Nb7N24LU8iy iKZ+p3BJ9Z8LgFZslncJgyV4DL9QY7Vv7r2Whp2JcgxnRlhFXgoTpEaT7qPuE+vRT7 mgMbxjI55vdR6JUpAW0kpi6XPMrZwzs7GE3wvY5YaVI65v5QqAZlX1O+cNLIuG//E1 uKbn1hJ/I8hnE2CbT8PIcLDLbrvefSyn46tQ4FgkbONbfdr/3vqnYr5pMEy2rJEjK7 d3FBqmmDUNIlO+ZJhjSQmyifEktClWVMrAZMk88mCTTpxOwwGeUWsOQ6iRJOoK2kRS c5+ZCJCH6He9Q== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D33F5604E7 for ; Wed, 16 Mar 2022 10:39:55 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="vQgYOi1Q"; dkim-atps=neutral Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:3036:4976:879c:5c94]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 765BEA67; Wed, 16 Mar 2022 10:39:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1647423595; bh=39nx0jN/BSL7NAeiCDh5ROPoY0goom8ufH1EyAcYehc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vQgYOi1Q5xP7KwL50i4O5pB2KJNaIcfOY84seeRzlCz0UZMUtk9bSZu1VKg8wKFMy PeRzGiMB83GOG6f8z/rQfGs+CDRwq6WT5asEiXa6JunrMGiYs3q3rFCUBHuCJPRKum scatF/6Zeo1vrMYebTjsFwjcUT/AfKr3yKu29KgU= To: libcamera-devel@lists.libcamera.org Date: Wed, 16 Mar 2022 10:39:51 +0100 Message-Id: <20220316093951.33779-2-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220316093951.33779-1-jeanmichel.hautbois@ideasonboard.com> References: <20220316093951.33779-1-jeanmichel.hautbois@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: Control the lens position X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jean-Michel Hautbois via libcamera-devel From: Jean-Michel Hautbois Reply-To: Jean-Michel Hautbois Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that the ancillary links are configured, we can use the CameraLens class and control the VCM through the IPA. For now, force a default value for the lens position, until the AF algorithm is introduced. Signed-off-by: Jean-Michel Hautbois --- src/ipa/raspberrypi/raspberrypi.cpp | 38 +++++++++++++++++++++++++++-- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index fd8fecb0..0a0b5a3a 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -108,6 +108,7 @@ private: void setMode(const IPACameraSensorInfo &sensorInfo); bool validateSensorControls(); bool validateIspControls(); + bool validateLensControls(); void queueRequest(const ControlList &controls); void returnEmbeddedBuffer(unsigned int bufferId); void prepareISP(const ipa::RPi::ISPConfig &data); @@ -132,6 +133,7 @@ private: ControlInfoMap sensorCtrls_; ControlInfoMap ispCtrls_; + ControlInfoMap lensCtrls_; ControlList libcameraMetadata_; /* Camera sensor params. */ @@ -342,13 +344,14 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo, const ipa::RPi::IPAConfig &ipaConfig, ControlList *controls) { - if (entityControls.size() != 2) { - LOG(IPARPI, Error) << "No ISP or sensor controls found."; + if (entityControls.size() != 3) { + LOG(IPARPI, Error) << "No ISP, lens or sensor controls found."; return -1; } sensorCtrls_ = entityControls.at(0); ispCtrls_ = entityControls.at(1); + lensCtrls_ = entityControls.at(2); if (!validateSensorControls()) { LOG(IPARPI, Error) << "Sensor control validation failed."; @@ -360,6 +363,11 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo, return -1; } + if (!validateLensControls()) { + LOG(IPARPI, Error) << "Lens control validation failed."; + return -1; + } + maxSensorGainCode_ = sensorCtrls_.at(V4L2_CID_ANALOGUE_GAIN).max().get(); /* Setup a metadata ControlList to output metadata. */ @@ -578,6 +586,23 @@ bool IPARPi::validateIspControls() return true; } +bool IPARPi::validateLensControls() +{ + static const uint32_t ctrls[] = { + V4L2_CID_FOCUS_ABSOLUTE, + }; + + for (auto c : ctrls) { + if (lensCtrls_.find(c) == lensCtrls_.end()) { + LOG(IPARPI, Error) << "Unable to find lens control " + << utils::hex(c); + return false; + } + } + + return true; +} + /* * Converting between enums (used in the libcamera API) and the names that * we use to identify different modes. Unfortunately, the conversion tables @@ -1066,6 +1091,15 @@ void IPARPi::processStats(unsigned int bufferId) setDelayedControls.emit(ctrls); } + + /* + * Set the focus position + * \todo Use an AF algorithm and replace the arbitrary value + */ + ControlList lensCtrls(lensCtrls_); + lensCtrls.set(V4L2_CID_FOCUS_ABSOLUTE, static_cast(123)); + setLensControls.emit(lensCtrls); + } void IPARPi::applyAWB(const struct AwbStatus *awbStatus, ControlList &ctrls)