From patchwork Wed Mar 9 15:26:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 15435 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AD911BE08A for ; Wed, 9 Mar 2022 15:26:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E26CC6118B; Wed, 9 Mar 2022 16:26:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1646839578; bh=hD1TSPH0zzQ4sd/6g85fylEZEK/lmcFfVgmIJM23zZM=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=HXgN07Ljc2nX9d4CxBDn73Q2314fJ+VttjEoH521YxOWrC98k06xjP/Buk+kB+CvU ZZM0Z+McUm/DW8eepuO1LE4teOwZKNziKrwErLaxWAxEW98RpC3fLStq/M4xK89StF BHnPXiJv5TR8OV/MBAEmwbdh5KUM9CFGiK4/p+sB6lozdLffxOrHurQ+VVDt4WGWPD iRy6kUFUWFUQgsdtYaD6KEmCRjO2zDiCXqK6J/EkryHUWKqVETU+mOeiqwe62vyPDD 9MN1YI3T6ME9JjYhhcbB40z3N9DGUVT1O7DZeQkLtjtXe0y0/9ExE7yv+Qh2PdxvA+ OIyr84PmN6CmA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 345C260475 for ; Wed, 9 Mar 2022 16:26:18 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HrmVLHiH"; dkim-atps=neutral Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:3734:287e:1a7f:9772]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B10588C4; Wed, 9 Mar 2022 16:26:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1646839577; bh=hD1TSPH0zzQ4sd/6g85fylEZEK/lmcFfVgmIJM23zZM=; h=From:To:Cc:Subject:Date:From; b=HrmVLHiHngpt06lSdzHRoZPbcH6mNh8De2e1bhTIX/1EHoAczloeRofZ1o96iICr9 o8f4WGxomHc86Qul0dHxlNCXIXz6Zyk4P1a+1jQUzHksGircretuwatHWd4NEcOAIm rGsi591GA++84bI3xSuYydQtFnPfwYeC/UZ1mCmA= To: libcamera-devel@lists.libcamera.org Date: Wed, 9 Mar 2022 16:26:14 +0100 Message-Id: <20220309152614.776224-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: Fix typo in a function name for camera lens class X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jean-Michel Hautbois via libcamera-devel From: Jean-Michel Hautbois Reply-To: Jean-Michel Hautbois Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The CameraLens class implements a function named "setFocusPostion". There is a typo here, fix it. While at it fix it in the IPU3 IPA as it is used only here. Signed-off-by: Jean-Michel Hautbois Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- include/libcamera/internal/camera_lens.h | 2 +- src/libcamera/camera_lens.cpp | 2 +- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h index 6f2ea1bc..ff4d066e 100644 --- a/include/libcamera/internal/camera_lens.h +++ b/include/libcamera/internal/camera_lens.h @@ -24,7 +24,7 @@ public: ~CameraLens(); int init(); - int setFocusPostion(int32_t position); + int setFocusPosition(int32_t position); const std::string &model() const { return model_; } diff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_lens.cpp index 189cb025..810fcffa 100644 --- a/src/libcamera/camera_lens.cpp +++ b/src/libcamera/camera_lens.cpp @@ -84,7 +84,7 @@ int CameraLens::init() * * \return 0 on success or -EINVAL otherwise */ -int CameraLens::setFocusPostion(int32_t position) +int CameraLens::setFocusPosition(int32_t position) { ControlList lensCtrls(subdev_->controls()); lensCtrls.set(V4L2_CID_FOCUS_ABSOLUTE, static_cast(position)); diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 6c5617cd..03259d0e 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -1267,7 +1267,7 @@ void IPU3CameraData::queueFrameAction(unsigned int id, const ControlValue &focusValue = lensControls.get(V4L2_CID_FOCUS_ABSOLUTE); - focusLens->setFocusPostion(focusValue.get()); + focusLens->setFocusPosition(focusValue.get()); break; }