From patchwork Mon Feb 7 15:12:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 15342 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DB374BF415 for ; Mon, 7 Feb 2022 15:12:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E8BDF61086; Mon, 7 Feb 2022 16:12:21 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="VcMqomsA"; dkim-atps=neutral Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 578B16105F for ; Mon, 7 Feb 2022 16:12:20 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id k127-20020a1ca185000000b0037bc4be8713so2324943wme.3 for ; Mon, 07 Feb 2022 07:12:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b+ZMf4eVFVMwWoM8wQemRo2DNOLvFAHjzpnIVlUsGZA=; b=VcMqomsArDG5ggX5CD68jYsKFJA43PJXI+K4x+ZYQDOd8GDlD4i75MgBjxpvjhWn0B FxzQwefq0UodfG3rSSy462GbfVVp8H5H5YS1n6/QcmeT9yIqXG27cAajkF3KUQ8JNsH3 Bm/VntCNg5r6oym+XNMsnii0wQfsMZeYEshuc8yf2pNhyO9lNxkQzcYtkpWWP2AtI5oW iZfDAaZdH6oMEg1+GcHZAZnwO7MSzxcb8zWcO1iNYnIgHcqSz18U64e7t0g5Tlxlt9H+ dFNZUMg9LxU5nD8DLsQf9U73T3x6IKRWtTWSqsYtYZQZIWivtGBrpD0CytKTJDzrnBuP RYoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b+ZMf4eVFVMwWoM8wQemRo2DNOLvFAHjzpnIVlUsGZA=; b=Mh3x7wczs5stvLGBF0k2yIP5ofKNP3TXbnHL3RrQdGkevu26Aqy0OO9UCpS+tkjrWj VBNbssp2fK49U/ObCRudut/dtSY5kxqm/K9Fso+ph5FM36C8TC2P9cmatMbsL1zQW6NU rNaKgCj6f+WMTJbz30kfBMRs+a0Bs1KDriBOycU1Vcy0yr2jsMJQmyZVkvg7k0cVy0ZB T3/AHRskTIb6l3VYR5grE4yfnaizLGogF9WnEw0ug5UpPNJuxts/wD3cVVAN6GVhnDyn pIzQW2CrlNztz4mLC6xTAcDC7BNfvBlIo0LBhLhk99L25t7L+uvDJEi+zl7lZCLXs2rY d3cg== X-Gm-Message-State: AOAM533ljT+eyb9qgWaIouDCjTY9k64a2V0sgou5pXjO2aNNpl6Bwg57 a6tubjE93FXLiFUidyS3khBFNudx7memlQ== X-Google-Smtp-Source: ABdhPJzT972KDBiuVx9lzCi371BC8EZUTIWnwsgHA9gpHF3EGOqWWIF07P/7b710luBs2tasazEh+w== X-Received: by 2002:a7b:cb9a:: with SMTP id m26mr24052wmi.18.1644246739861; Mon, 07 Feb 2022 07:12:19 -0800 (PST) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:4a96:1adf:459f:8a7e]) by smtp.gmail.com with ESMTPSA id i19sm21463085wmq.45.2022.02.07.07.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 07:12:19 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 7 Feb 2022 15:12:14 +0000 Message-Id: <20220207151214.887140-3-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220207151214.887140-1-naush@raspberrypi.com> References: <20220207151214.887140-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Reduce the controller rate to 30fps X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" With the controller algorithms running at 60fps, there are some dropped frames when running at very high famerates. Reducing this to 30fps eliminates all these drops without any noticeable changes to the image quality. Signed-off-by: Naushir Patuck Reviewed-by: Laurent Pinchart Reviewed-by: David Plowman --- src/ipa/raspberrypi/raspberrypi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index a72d516f84ee..fd8fecb07f81 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -70,7 +70,7 @@ constexpr Duration defaultMaxFrameDuration = 250.0s; * we rate-limit the controller Prepare() and Process() calls to lower than or * equal to this rate. */ -constexpr Duration controllerMinFrameDuration = 1.0s / 60.0; +constexpr Duration controllerMinFrameDuration = 1.0s / 30.0; LOG_DEFINE_CATEGORY(IPARPI)