From patchwork Fri Feb 4 13:38:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 15328 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AFF81BDCBF for ; Fri, 4 Feb 2022 13:38:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id ED246609E1; Fri, 4 Feb 2022 14:38:44 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GmuEzxhc"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B7566609A9 for ; Fri, 4 Feb 2022 14:38:42 +0100 (CET) Received: from deskari.lan (91-156-85-209.elisa-laajakaista.fi [91.156.85.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 331F9475; Fri, 4 Feb 2022 14:38:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1643981922; bh=ONUtTujr3cB+0P01cje8BCjDYxRpLDD+pm2TluEsvE8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GmuEzxhc/G4MpxOl4aCO6QCLYQnlonOqZcTu2YFPpcFI1e0ywqnREwuAS/Kq8L0xH r+TjdRgr/D53W3Kacrlf36e4MI9dHbTLaBILf+Ga9a6Mkg7jpMJFqAAIJpfAQFlHnp 72VcJ2y94X+Xo4hRzwWDGUsmObwfyeMQLQHJen/I= From: Tomi Valkeinen To: libcamera-devel@lists.libcamera.org, David Plowman , Kieran Bingham , Laurent Pinchart Date: Fri, 4 Feb 2022 15:38:10 +0200 Message-Id: <20220204133814.303217-2-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220204133814.303217-1-tomi.valkeinen@ideasonboard.com> References: <20220204133814.303217-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 1/5] HACK: libcamera: Camera public destructor X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" pybind11 needs a public destructor for Camera to be able to manage the shared_ptr. It's not clear why this is needed, and can it be fixed in pybind11. Looks like there's a suggested fix, which has not been merged: https://github.com/pybind/pybind11/pull/2067 Signed-off-by: Tomi Valkeinen --- include/libcamera/camera.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h index 5bb06584..e753cd23 100644 --- a/include/libcamera/camera.h +++ b/include/libcamera/camera.h @@ -114,12 +114,12 @@ public: int start(const ControlList *controls = nullptr); int stop(); + ~Camera(); private: LIBCAMERA_DISABLE_COPY(Camera) Camera(std::unique_ptr d, const std::string &id, const std::set &streams); - ~Camera(); friend class PipelineHandler; void disconnect();