From patchwork Tue Dec 28 21:59:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 15227 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7A52FBF415 for ; Tue, 28 Dec 2021 22:00:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8ADFB60913; Tue, 28 Dec 2021 22:59:59 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UbClrQaV"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BBD73608E9 for ; Tue, 28 Dec 2021 22:59:57 +0100 (CET) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6203E895 for ; Tue, 28 Dec 2021 22:59:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1640728797; bh=3I3vAIHb+uMi8YL3WHkzjPZoLjHt0cqbeCgCRKbR1Jw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=UbClrQaVBKFcoADjT6mgtdjtfhCAlBxxPo9+oaOa89KUhJ751MbkkAr6Q7bByUXd7 U0O8V29OE73is/xpQYguaZSwzxIOlnoa+0zt+hIOfaqaQV0cHjOz/3E1HqbF4Lmnte hAzPOAlKVPd4Bu6g8JfyRHNdGvBTSpNm2X7r+bWk= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 28 Dec 2021 23:59:47 +0200 Message-Id: <20211228215951.32396-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211228215951.32396-1-laurent.pinchart@ideasonboard.com> References: <20211228215951.32396-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 1/5] v4l2: v4l2_compat_manager: Print path and fd in openat() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The V4L2 compat layer prints debug messages that mention the file descriptor of the video device, but no message that links the device path to the file descriptor. Fix it by adding a debug message in openat(). Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Paul Elder --- src/v4l2/v4l2_compat_manager.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp index 690a191fe2bf..c64cdb862489 100644 --- a/src/v4l2/v4l2_compat_manager.cpp +++ b/src/v4l2/v4l2_compat_manager.cpp @@ -158,6 +158,7 @@ int V4L2CompatManager::openat(int dirfd, const char *path, int oflag, mode_t mod V4L2CameraProxy *proxy = proxies_[ret].get(); files_.emplace(efd, std::make_shared(efd, oflag & O_NONBLOCK, proxy)); + LOG(V4L2Compat, Debug) << "Opened " << path << " -> fd " << efd; return efd; }