From patchwork Tue Dec 21 05:21:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 15195 X-Patchwork-Delegate: paul.elder@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 255B5BE080 for ; Tue, 21 Dec 2021 05:21:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CD0B9608E9; Tue, 21 Dec 2021 06:21:40 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="r3I7P/0g"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EB353608FB for ; Tue, 21 Dec 2021 06:21:37 +0100 (CET) Received: from pyrite.mediacom.info (unknown [IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C2AD2881; Tue, 21 Dec 2021 06:21:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1640064097; bh=VOQfVebVjXwrTly6/GGhEjKGuvOlMczEomtQdFuSBas=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r3I7P/0g5ETMhz5wz4DuQErEGBdwDftrrz0EkP3CYQsrwzUEfxRE7oYqvptYhtN36 76gsRSqgQwUw1CghBzRrgh+RJ+LnB1MM0jjsvkrl32x4gJ/dNCfLcVnvXcxV57TnpK se/6sQ/BK5Mo9KLZiWuxDYbFeqlQZDvurEH1JMJU= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Mon, 20 Dec 2021 23:21:14 -0600 Message-Id: <20211221052117.2665228-2-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20211221052117.2665228-1-paul.elder@ideasonboard.com> References: <20211221052117.2665228-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/3] properties: Add SensorFixedBlackLevels X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add a property to store the black levels, which are the zero light values for each color channel specified in the CFA. We already have a similar control that reports dynamic black levels, but we also need a static one. Bug: https://bugs.libcamera.org/show_bug.cgi?id=48 Signed-off-by: Paul Elder --- src/libcamera/property_ids.yaml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml index 12ecbce5..99067144 100644 --- a/src/libcamera/property_ids.yaml +++ b/src/libcamera/property_ids.yaml @@ -678,6 +678,23 @@ controls: \todo Turn this property into a "maximum control value" for the ScalerCrop control once "dynamic" controls have been implemented. + - SensorFixedBlackLevels: + type: int32_t + size: [4] + description: | + A fixed black level offset for each of the color filter arrangement + (CFA) mosaic channels. + + This property specifies the zero light value for each of the CFA mosaic + channels in the camera sensor. + + The values are given in the same order as channels listed for the CFA + layout key i.e. the nth value given corresponds to the black level + offset for the nth color channel listed in the CFA. If the CFA is MONO, + all four channels shall have the same values. + + \sa ColorFilterArrangement + # ---------------------------------------------------------------------------- # Draft properties section