From patchwork Mon Dec 20 23:26:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 15172 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CC09CC3258 for ; Mon, 20 Dec 2021 23:26:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6CC28608F8; Tue, 21 Dec 2021 00:26:47 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BsIrXDOc"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1976A60868 for ; Tue, 21 Dec 2021 00:26:45 +0100 (CET) Received: from pyrite.mediacom.info (unknown [IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6BE04FD7; Tue, 21 Dec 2021 00:26:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1640042804; bh=5ShqKvB4tAmbmPpPVg2CCf6TooLNTQlMBVt2nKauTmE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BsIrXDOcsFcSXZyu8qbbweyfXzu/ivPgZcDcWmoVq4BTuyoS9EJOb45lCWcP/OECD EPWNrk5X2h87c+RSyYu4dQsF3VH5DQaKEvXApwRKEtdEaBegfGW3DjKS6c+qbf6knM j8mLxQkvq/FQ9/OoU73qV6fQoBEvywAIMISB6Ils= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Mon, 20 Dec 2021 17:26:24 -0600 Message-Id: <20211220232629.1485890-2-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20211220232629.1485890-1-paul.elder@ideasonboard.com> References: <20211220232629.1485890-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/6] android: camera_capabilities: Add messages for lack of FULL support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Print messages when some feature is missing that causes hardware level FULL to not be supported. Signed-off-by: Paul Elder Reviewed-by: Jacopo Mondi Reviewed-by: Umang Jain --- src/android/camera_capabilities.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp index c4c26089..6ae2cd4d 100644 --- a/src/android/camera_capabilities.cpp +++ b/src/android/camera_capabilities.cpp @@ -359,6 +359,9 @@ void CameraCapabilities::computeHwLevel( { camera_metadata_ro_entry_t entry; bool found; + + const char *noFull = "Hardware level FULL unavailable: "; + camera_metadata_enum_android_info_supported_hardware_level hwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL; @@ -372,8 +375,10 @@ void CameraCapabilities::computeHwLevel( hwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED; found = staticMetadata_->getEntry(ANDROID_SYNC_MAX_LATENCY, &entry); - if (!found || *entry.data.i32 != 0) + if (!found || *entry.data.i32 != 0) { + LOG(HAL, Info) << noFull << "missing or invalid max sync latency"; hwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED; + } hwLevel_ = hwLevel; }