From patchwork Mon Dec 13 14:51:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 15150 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7A646BDB13 for ; Mon, 13 Dec 2021 14:50:58 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 42FF060897; Mon, 13 Dec 2021 15:50:58 +0100 (CET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7071D60868 for ; Mon, 13 Dec 2021 15:50:54 +0100 (CET) Received: (Authenticated sender: jacopo@jmondi.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 0ED0460002; Mon, 13 Dec 2021 14:50:53 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Mon, 13 Dec 2021 15:51:42 +0100 Message-Id: <20211213145143.218734-2-jacopo@jmondi.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211213145143.218734-1-jacopo@jmondi.org> References: <20211213145143.218734-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] test: fence: Check write return value X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The ::write() function used to signal a framebuffer fence in the unit test is marked with the 'warn_unused_result'. When building in debugoptimized mode not checking for the return value causes issues at build time: /test/fence.cpp:254:2: error: ignoring return value of function declared with 'warn_unused_result' attribute Fix that by checking the ::write() return value and emitting an error message in case the write fails. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Tested-by: Laurent Pinchart Reviewed-by: Umang Jain --- test/fence.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/fence.cpp b/test/fence.cpp index d2dfc9b615a9..d2865398784e 100644 --- a/test/fence.cpp +++ b/test/fence.cpp @@ -251,7 +251,12 @@ void FenceTest::requestComplete(Request *request) void FenceTest::signalFence() { uint64_t value = 1; - write(efd2_, &value, sizeof(value)); + int ret; + + ret = write(efd2_, &value, sizeof(value)); + if (ret != sizeof(value)) + cerr << "Failed to signal fence" << endl; + dispatcher_->processEvents(); }