From patchwork Thu Dec 9 09:29:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 15085 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E2949BF415 for ; Thu, 9 Dec 2021 09:29:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 683556087A; Thu, 9 Dec 2021 10:29:45 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JTZ434ti"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 583EF60224 for ; Thu, 9 Dec 2021 10:29:43 +0100 (CET) Received: from deskari.lan (91-156-85-209.elisa-laajakaista.fi [91.156.85.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DC8BE5B0; Thu, 9 Dec 2021 10:29:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1639042183; bh=1u51IMESkICKFHOsJqttPhu0FTY3Cp+//IgKE+oJuXw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JTZ434tigNz9b5C/fuxvbBF5fCyBD4HUYK3AxPKrSPFPUQ1vvWJ/5eUFN6P/bTUlu qbVG4Ag0SWAE+HxVi4bmajGfidSl6lLMl2Uh9GPXEtufrobtR2LywOLf+ZRMAWd1lg DvpDqhFe9Dt5w6oMop5xp+QB/V7ng5s82yvUkCH8= From: Tomi Valkeinen To: libcamera-devel@lists.libcamera.org Date: Thu, 9 Dec 2021 11:29:02 +0200 Message-Id: <20211209092906.37303-2-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211209092906.37303-1-tomi.valkeinen@ideasonboard.com> References: <20211209092906.37303-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [RFC v3 1/5] HACK: Camera public destructor X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" pybind11 needs a public destructor for Camera to be able to manage the shared_ptr. It's not clear why this is needed, and can it be fixed in pybind11. Signed-off-by: Tomi Valkeinen --- include/libcamera/camera.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h index a7759ccb..88a61ff5 100644 --- a/include/libcamera/camera.h +++ b/include/libcamera/camera.h @@ -104,12 +104,12 @@ public: int start(const ControlList *controls = nullptr); int stop(); + ~Camera(); private: LIBCAMERA_DISABLE_COPY(Camera) Camera(std::unique_ptr d, const std::string &id, const std::set &streams); - ~Camera(); friend class PipelineHandler; void disconnect();