From patchwork Wed Dec 1 20:15:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 14984 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 126C2BDB13 for ; Wed, 1 Dec 2021 20:15:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C857E60822; Wed, 1 Dec 2021 21:15:54 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YQcRWd28"; dkim-atps=neutral Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 778D5607DE for ; Wed, 1 Dec 2021 21:15:53 +0100 (CET) Received: by mail-pl1-x62a.google.com with SMTP id z6so18584556plk.6 for ; Wed, 01 Dec 2021 12:15:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cE1vm2CFjn+Kghm8OVlr501+csj7p2wEwNyWyemkUxg=; b=YQcRWd28sSt5k6oDLTi1GBkEaPAODimmfDAGmsBtKXYkwtpONGc3RskCoRZCwY4fjs 0LFq5hFz7yImzJz+jZVb/8eSs4zwNsuLvLYJeWRiHY5ESgIMOeJDB0+vsPxC+R0f18pU Sh9n314b5+GflDZyOaWqHZnBABKos+gKZPE146U5MKnIoapSIsTMxZNkRAZ62x8ix5h/ 3MgrkwvYdtWqiHYuEkenEM4f22A1QhPsq5TqeMhLLeckejsS8cix1+Ghv+wXaY6wJm+/ h6OTXB7yvKLEYYsK7/+KWWm7c6os8HlFvYNJYJfD3innUZI1RmpmeKbpQtmDsrmDjOFA V41w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cE1vm2CFjn+Kghm8OVlr501+csj7p2wEwNyWyemkUxg=; b=qAXoEqJooWBcyLdWt9P6avNfyr84Fu4C6lPf7IY0bJ5Q5B0xwHmqV9jiIDCxvVLg7M YQzortedIXcaAXmDaCQs+JsGdvMWbI2VDrb1OcHG0EDTxwze0zpjIAK3J8zMGrA1W9ln V+rMXYlgy+8rvqyBFXVAfCfGduzQzO3ULAnGxj8Wurg/jfjHgGoH62Y4VOOa6ZooptIo aSL8NqncrIcB0n8Ic0uB0X8CTBHXOocfCC8lGVWZfbQdN7pJMziZM84sxvNHlfJcuLwv 12i+N+HT8lZMYxtQI8uxbo7H6JZ6CmdYwsoT9pqOk4ika+qMskbZaowH7OUIflTNbcdu 9j0g== X-Gm-Message-State: AOAM533y9k4xlWgTwoXw/U7XMku8DRN0tl2nt3+K/6t8Nu2765M/H4cv smKCDgrkIJwXzAQOKTEe+y9KmmGUif/XxQ== X-Google-Smtp-Source: ABdhPJyoWvzCvCcreo0rFQlbZpw8SY6XNe2b7Y7todmF0cS+ltwdw3lMzwnLSTG/JK2AXJZb+LmCYw== X-Received: by 2002:a17:902:ecca:b0:141:e920:3b71 with SMTP id a10-20020a170902ecca00b00141e9203b71mr10065598plh.10.1638389751478; Wed, 01 Dec 2021 12:15:51 -0800 (PST) Received: from apollo.hsd1.ca.comcast.net ([2601:646:9200:a0f0::ce68]) by smtp.gmail.com with ESMTPSA id 66sm449822pgg.63.2021.12.01.12.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 12:15:50 -0800 (PST) From: Khem Raj To: libcamera-devel@lists.libcamera.org Date: Wed, 1 Dec 2021 12:15:48 -0800 Message-Id: <20211201201548.2023225-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2] backtrace: Include cxxabi.h without HAVE_DW X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Khem Raj Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Since its used in code without HAVE_DW, it fails to compile on such systems e.g. linux/musl Fixes src/libcamera/base/backtrace.cpp:235:16: error: use of undeclared identifier 'abi' char *name = abi::__cxa_demangle(symbol, nullptr, nullptr, nullptr); ^ 1 error generated. Signed-off-by: Khem Raj Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- v2: Fix typo in subject src/libcamera/base/backtrace.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/base/backtrace.cpp b/src/libcamera/base/backtrace.cpp index d93e5518..42c60f7c 100644 --- a/src/libcamera/base/backtrace.cpp +++ b/src/libcamera/base/backtrace.cpp @@ -13,11 +13,12 @@ #endif #ifdef HAVE_DW -#include #include #include #endif +#include + #if HAVE_UNWIND /* * Disable support for remote unwinding to enable a more optimized