From patchwork Tue Nov 30 07:10:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 14880 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 034AEBF415 for ; Tue, 30 Nov 2021 07:11:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 32341605B4; Tue, 30 Nov 2021 08:11:04 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="tUaBKJci"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C61DE604FC for ; Tue, 30 Nov 2021 08:11:02 +0100 (CET) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:699a:a10f:5b1e:89b7]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 47B608F0; Tue, 30 Nov 2021 08:11:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1638256262; bh=hKLep240VxNo0La3mct+ZFRNgmiLKbS3Bjgm3bkgDio=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tUaBKJciSdoxfbeuG1Mf6CpcHc9VynKfPNZmkRmy0NrwubGoF1y8NQddFyGSbmUTO 4L96bIgBVRheIoAFDe4rxa3+IlGypsNvD95Ks0/JSkZrKg4KzN7ZblU2IKFozTKcH6 1IV6BxkK36O5TlbY1uw2dtDgD7ZbE4oizNqV/WTY= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Nov 2021 08:10:58 +0100 Message-Id: <20211130071058.47834-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211130064547.37598-1-jeanmichel.hautbois@ideasonboard.com> References: <20211130064547.37598-1-jeanmichel.hautbois@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1.1] ipa: rkisp1: Initialize numCells in constructor X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The non-static class member "numCells_" is not initialized in the constructor. Fix it. Reported-by: Coverity CID 365801 Signed-off-by: Jean-Michel Hautbois Reviewed-by: Umang Jain Reviewed-by: Kieran Bingham --- src/ipa/rkisp1/algorithms/agc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index 650fe2dae..d6abdc310 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -53,7 +53,7 @@ static constexpr uint32_t kNumStartupFrames = 10; static constexpr double kRelativeLuminanceTarget = 0.4; Agc::Agc() - : frameCount_(0), filteredExposure_(0s) + : frameCount_(0), numCells_(0), filteredExposure_(0s) { }