From patchwork Mon Nov 29 17:10:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 14850 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 07BA2BDB13 for ; Mon, 29 Nov 2021 17:10:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4AD4D605A4; Mon, 29 Nov 2021 18:10:46 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Sx59GKWn"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 797B060592 for ; Mon, 29 Nov 2021 18:10:44 +0100 (CET) Received: from perceval.ideasonboard.com (unknown [103.251.226.170]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E49AF1265; Mon, 29 Nov 2021 18:10:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1638205844; bh=cfX1iboCAswCSvuJG6RF7DgPyrB4Q96BTZK4rFCzUis=; h=From:To:Cc:Subject:Date:From; b=Sx59GKWnl0dgom8IdtMJtYFXeD4KNSGZ5VioLqXjLIT2wO/5dlr0M1a6H9PUNWGzt +y6Jw3PORStkiETP2vU653uqKdJuKYlTrPNxp0ZRjC1UM4vdKi16gdWw3hTTu1QkVT cT7KPqEFjfOkMg+OhQjVkrQr23EwhGk8Ix5HUZ0A= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Nov 2021 22:40:32 +0530 Message-Id: <20211129171032.469605-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] ipu3: ipa: Report correct exposure in request metadata X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" While populating the ControlList for the request's metadata, the exposure value should be used computed from AGC algorithm instead of sensor's exposure. The issue is caught while debugging a FULL-level CTS test. Signed-off-by: Umang Jain Reviewed-by: Jean-Michel Hautbois --- src/ipa/ipu3/ipu3.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index a8d54a5d..9cd80a02 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -632,7 +632,7 @@ void IPAIPU3::parseStatistics(unsigned int frame, ctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK); - ctrls.set(controls::ExposureTime, context_.frameContext.sensor.exposure * lineDuration_.get()); + ctrls.set(controls::ExposureTime, context_.frameContext.agc.exposure * lineDuration_.get()); /* * \todo The Metadata provides a path to getting extended data