From patchwork Thu Nov 25 13:12:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 14780 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 76F27BF415 for ; Thu, 25 Nov 2021 13:12:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3360B6038A; Thu, 25 Nov 2021 14:12:38 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="dY55Ap+g"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CC9760231 for ; Thu, 25 Nov 2021 14:12:37 +0100 (CET) Received: from perceval.ideasonboard.com (unknown [103.251.226.170]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F63790E; Thu, 25 Nov 2021 14:12:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1637845956; bh=idN1gzWVOJ0dF/QtSg/Tq3HzgFp1FOOxsE0dD53h8Jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dY55Ap+g95tiM7KRnI5Luk7ihvBaHFHdCVI7BeaSXVBvuXXvvQaqf9F34Y+vtF7u5 AVOynFW6y08PlH3kimDErfGAt8So8/mRqBnCy9cYhu03CyFE/BXHx3Tq3RGYx9BsTn w7Y3hJzBWsXMdr5PS4oA3gN2nK1u2s/vtkwSh2pg= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Thu, 25 Nov 2021 18:42:23 +0530 Message-Id: <20211125131224.927640-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211125131224.927640-1-umang.jain@ideasonboard.com> References: <20211125131224.927640-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/2] android: camera_device: Provide toString() helper for stream_type X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Provide a directionToString() helper to return a human-friendly name for camera3_stream_t->stream_type. Replace the int value being printed in configureStreams() INFO log with directionToString(). Signed-off-by: Umang Jain Reviewed-by: Jacopo Mondi Reviewed-by: Hirokazu Honda Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/android/camera_device.cpp | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index f2e0bdbd..ad4bf07c 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -175,6 +175,21 @@ const char *rotationToString(int rotation) return "INVALID"; } +const char *directionToString(int stream_type) +{ + switch (stream_type) { + case CAMERA3_STREAM_OUTPUT: + return "Output"; + case CAMERA3_STREAM_INPUT: + return "Input"; + case CAMERA3_STREAM_BIDIRECTIONAL: + return "Bidirectional"; + default: + LOG(HAL, Warning) << "Unknown stream type: " << stream_type; + return "Unknown"; + } +} + #if defined(OS_CHROMEOS) /* * Check whether the crop_rotate_scale_degrees values for all streams in @@ -548,7 +563,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list) PixelFormat format = capabilities_.toPixelFormat(stream->format); LOG(HAL, Info) << "Stream #" << i - << ", direction: " << stream->stream_type + << ", direction: " << directionToString(stream->stream_type) << ", width: " << stream->width << ", height: " << stream->height << ", format: " << utils::hex(stream->format)