From patchwork Fri Nov 12 10:03:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 14589 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CE636BF415 for ; Fri, 12 Nov 2021 10:03:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7E2CE60369; Fri, 12 Nov 2021 11:03:55 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="AMMhRK7p"; dkim-atps=neutral Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F6CB60234 for ; Fri, 12 Nov 2021 11:03:54 +0100 (CET) Received: by mail-wr1-x42a.google.com with SMTP id n29so14478132wra.11 for ; Fri, 12 Nov 2021 02:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3DsHUzto1xICrV+8oKQbV2fo+5EHRpl8Rwp/bFHynbY=; b=AMMhRK7p/PTuQPBjoY7S0Qal3ebR8jiz7ZS1zJcskOKTydC4aiEA6kH//ZtemWm+4N PvvYuy3izapBO2i0HQL1UXrmPtDad78q6PCgm8ldHdgCgVJAQuaEIHmM8utEM6SNE6pc 3UXijfrBWIENNNZC3RKbz8oS+7rDMZRX1/20DKTCKB23cQzp+l97apbsrJ0x3DYKHBZb sxdXSRsncUs1Tm0rp/13oR4W3RWc8IcedJR+IbUFBWoHjujgvQ1gPmmEdKblfxMdBF3/ 6GFpxrkmaxrFqL5DxbRkEJ4uySubDzgF9F1HQ8jnoITJxGV/4AMqrWhym5NVaEfsLql1 5Jxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3DsHUzto1xICrV+8oKQbV2fo+5EHRpl8Rwp/bFHynbY=; b=dsXyEwprUym7wf8pYsRLgzlnS5iqy5eKgroKuPGayXeu7XQO5CScZiz5R61MLLthlU 6znw7pwSsBpPbqg8TU+cd0KB8wcF2iXJwnqsgLdBt7HdZXgKmiNPMSHmQpfVWYL7yfqJ hTKfba2JHMtGN7VFyx3iY8WUylBq+yY81wcqVwwXvF58m0rQhw29iNWz8a85oz+NFR38 rEQ8JRTajSrxeZh+7lddJhbUSrQAa15OURaZMIQSjc2GuHzsiH+x8WKe6t7BUXOXbJiv 32xmsLNlqbxaR1EyHBR7lVpATHBgP5LQgQR7YK8DJM1n/aFL09SjF3LaSzAq7voHazT+ 62Ng== X-Gm-Message-State: AOAM533fIelrMmvEG5xLxOmZDc50wk2t48fnOqmpeQP17oGxIwo7zat5 kPFIhU8fZefU+SoSPOw9xWoR6/pe4DD3wPQh X-Google-Smtp-Source: ABdhPJzgmvxamQD3/yqa+Imafnc1ApHcdE10N3WlWK9e5TB7KEkJIxg5Lf868TOEAeizT3sDDsTanQ== X-Received: by 2002:adf:d1e2:: with SMTP id g2mr16599685wrd.179.1636711433839; Fri, 12 Nov 2021 02:03:53 -0800 (PST) Received: from naush-laptop.pitowers.org ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id o9sm5283155wrs.4.2021.11.12.02.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 02:03:53 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 12 Nov 2021 10:03:05 +0000 Message-Id: <20211112100305.2217099-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211112100305.2217099-1-naush@raspberrypi.com> References: <20211112100305.2217099-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 3/3] pipeline: raspberrypi: Increase the V4L2BufferCache slot allocations X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roman Stratiienko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" If a stream is marked as external, double the number of V4L2BufferCache slots that are allocated. This is to account for additional buffers that may be allocated directly by the application. Signed-off-by: Naushir Patuck Reviewed-by: Kieran Bingham Reviewed-by: Umang Jain Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp index b3265d0e8aab..67901936d6b6 100644 --- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp +++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp @@ -107,6 +107,14 @@ int Stream::prepareBuffers(unsigned int count) count = bufferMap_.size(); } + /* + * If this is an external stream, we must allocate slots for buffers that + * might be externally allocated. We have no indication of how many buffers + * may be used, so this might overallocate slots in the buffer cache. + */ + if (isExternal()) + count = count * 2; + return dev_->importBuffers(count); }