From patchwork Wed Nov 10 23:33:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 14543 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 51F99BDB1C for ; Wed, 10 Nov 2021 23:33:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B2B086034E; Thu, 11 Nov 2021 00:33:47 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nAIFW9xY"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 733B5600BF for ; Thu, 11 Nov 2021 00:33:46 +0100 (CET) Received: from Monstersaurus.ksquared.org.uk.beta.tailscale.net (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 025BB3E7; Thu, 11 Nov 2021 00:33:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1636587226; bh=Hpm6YN6TFI1yrNwFApXbU6aBBoHjGhwmVzgWTc536QA=; h=From:To:Cc:Subject:Date:From; b=nAIFW9xY3WG47PBlZfDHR9UeP7S1sREmmEF2+PhOBIpKhTH2odkZjaF9GT4F+r9Gi VPHb7vJP+f2mYk5jUvtPYHYwMlzpw9WZFskItQz5mR8+mNMYDijJ7/OnNoML6zvS7d vRWpdF6QwZg4JwH62P3swrejWYU6pQiELjja9VkI= From: Kieran Bingham To: libcamera devel Date: Wed, 10 Nov 2021 23:33:41 +0000 Message-Id: <20211110233341.2147832-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix minCrop indentation X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When updating the controls the calculation for minCrop incorrectly indents the parameters to scaledBy(). Fix it. Signed-off-by: Kieran Bingham Reviewed-by: Umang Jain Reviewed-by: Jacopo Mondi Reviewed-by: Paul Elder --- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index eb714aa61099..3cd7383f0e40 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -1039,7 +1039,7 @@ int PipelineHandlerIPU3::updateControls(IPU3CameraData *data) * top-left corner as we allow application to freely pan the crop area. */ Rectangle minCrop = Rectangle(minSize).scaledBy(analogueCrop.size(), - sensorInfo.outputSize); + sensorInfo.outputSize); controls[&controls::ScalerCrop] = ControlInfo(minCrop, maxCrop, maxCrop);