From patchwork Wed Nov 10 10:08:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 14517 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 845D5BDB1C for ; Wed, 10 Nov 2021 10:08:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C75386034A; Wed, 10 Nov 2021 11:08:11 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="lXkI4E6F"; dkim-atps=neutral Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A07CE6034E for ; Wed, 10 Nov 2021 11:08:08 +0100 (CET) Received: by mail-wr1-x435.google.com with SMTP id r8so3000096wra.7 for ; Wed, 10 Nov 2021 02:08:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l65rxfveEruSiHLvSJ6ZxHP4Un5MGATlNW0H1XExuqw=; b=lXkI4E6FhgHVJV1IrOX5sKYotSWsb2791INayvCwR402GDDPih+Yx/xQvzsRNgCS4m qMmBeYtTWUba6iqSEuwlgwWJQZ73MgyTKbhiJTaVKV6OZUuK2xwJxklCbukI4qK5AYJe 1uerXDG3J/1cRCNnDTlt8s9++/dYxWqBXr8zDnGc8D6yooigAmwgR2chkPhxjcj2U5ik Q8i+eeCld8kl68TryaYTZeocap7jqmTdfc0fxI+mutu1mVjOYY4FcMyJuPe5DueJXPxJ uo1Rd+wWMZaz5QrtNaN+H6Yy08r2b2QSHa02wjWjMY9cLRnT28bSL2cPAFQX7DgRvhxN 4r6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l65rxfveEruSiHLvSJ6ZxHP4Un5MGATlNW0H1XExuqw=; b=lOWT8/96zdnn8h8g1MHTgjY3XvlMOV/4u4nroPOjHx6t4p0eO/vTn9mU8tqmvaeKeT 1UtDqdHxTSMFfU/eG3gst8rMCy35YDG+k9Zfcmp4F7BImno7lm1UKdKLbyrReOP+0G9b +b9S+wysZbK5n9XVeJnOjsSKYVdRlg/zE2gLGJGkWphcuDKIvaZPzk8wo8L3ILgHRp52 J8z+A1Fkq+ej3v0WvsGb0d9RQN5dabq/icLH0U0Brpog5Se36PPbb1Vu2+zeNJxvoC/M kNNmDCQQtQCq+rEXA5ga6XLSVfEPTrE78NRf8HMwvSaCFBSWLvSkk47fXGZEXT1WFSd7 54oQ== X-Gm-Message-State: AOAM530p73iATXt+LkkgKlgAudZDKbACTDBFsSfsBOTTjRICk7b+36k7 JOd2YcMl8rTolnVYFGnuWxHbtIEc2ptO5Wwc X-Google-Smtp-Source: ABdhPJxDz4Fr4dIWmhI217CGdAd19BXUcHL+SL62t/QBGQylimx2s427U8EKopkMDHgoUBrYqd1V/w== X-Received: by 2002:adf:c70b:: with SMTP id k11mr17493046wrg.154.1636538888134; Wed, 10 Nov 2021 02:08:08 -0800 (PST) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:8747:6ef9:ee17:3d59]) by smtp.gmail.com with ESMTPSA id d11sm21969133wrs.38.2021.11.10.02.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 02:08:07 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Wed, 10 Nov 2021 10:08:02 +0000 Message-Id: <20211110100802.349623-3-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211110100802.349623-1-naush@raspberrypi.com> References: <20211110100802.349623-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/3] pipeline: raspberrypi: Increase the V4L2BufferCache slot allocations X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roman Stratiienko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" If a stream is marked as external, double the number of V4L2BufferCache slots that are allocated. This is to account for additional buffers that may be allocated directly by the application. Signed-off-by: Naushir Patuck Reviewed-by: Kieran Bingham Reviewed-by: Umang Jain --- src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp index b3265d0e8aab..67901936d6b6 100644 --- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp +++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp @@ -107,6 +107,14 @@ int Stream::prepareBuffers(unsigned int count) count = bufferMap_.size(); } + /* + * If this is an external stream, we must allocate slots for buffers that + * might be externally allocated. We have no indication of how many buffers + * may be used, so this might overallocate slots in the buffer cache. + */ + if (isExternal()) + count = count * 2; + return dev_->importBuffers(count); }