From patchwork Mon Nov 8 13:13:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 14487 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 991BEC3252 for ; Mon, 8 Nov 2021 13:14:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4D7806049B; Mon, 8 Nov 2021 14:14:18 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="O66lnqQr"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E694060398 for ; Mon, 8 Nov 2021 14:14:02 +0100 (CET) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:c2bb:76d0:68d7:a9a5]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A187B187C; Mon, 8 Nov 2021 14:14:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1636377242; bh=rg5fIYEY9UfUrV1R3AkxL5UAWNSg3Nzf/MnmXTE7/P4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O66lnqQrwkulj98zx8CpJcpLXb/jSetQ2aQdXSgMkv3j6BYP5tM5ORLShAmSG7ig5 Hcbvw8XCyAqJYOrm81SSh9ARLaURWpwGklNfOAWa8VowmUqc84OGSWtLfGEhZdYD7v 8kMQmHgX6tWZZhfS54ys6bn+LI9/bxg8GP7t4DcI= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Mon, 8 Nov 2021 14:13:46 +0100 Message-Id: <20211108131350.130665-19-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com> References: <20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 18/22] ipa: ipu3: Move the sensor update controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" We want the setControls() to use the cached exposure_ and gain_ values, so move the frame context update of those variables into frameCompleted() call instead. Signed-off-by: Jean-Michel Hautbois --- src/ipa/ipu3/ipu3.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index b60ab7e7..9b20e8ab 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -534,6 +534,10 @@ void IPAIPU3::frameStarted([[maybe_unused]] unsigned int frame) void IPAIPU3::frameCompleted([[maybe_unused]] unsigned int frame) { + /* Apply the exposure and gain updated values */ + exposure_ = context_.frameContext->agc.exposure; + gain_ = camHelper_->gainCode(context_.frameContext->agc.gain); + /* * Remove the pointer from the queue, it should not be accessed * anymore and delete it. @@ -711,10 +715,6 @@ void IPAIPU3::setControls(unsigned int frame) IPU3Action op; op.op = ActionSetSensorControls; - /* Apply the exposure and gain updated values */ - exposure_ = context_.frameContext->agc.exposure; - gain_ = camHelper_->gainCode(context_.frameContext->agc.gain); - ControlList ctrls(ctrls_); ctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure_)); ctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain_));